Fix checkout ref for build workflow call#612
Open
dfangl wants to merge 1 commit into
Open
Conversation
…atest version of the main branch after commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With #611, the build trigger was changed to a workflow_call, if the update action finds an update and pushes a commit.
However, this approach has a flaw, mainly that the build action will checkout the commit based on the event that triggered the workflow in the first place - so now the parent of the commit pushed.
This leads to the repo being in the correct state, but the workflow picking up the previous one and not pushing the correct image.
We can see that in this workflow run, the previous commit was checked out:
https://github.com/factoriotools/factorio-docker/actions/runs/26247031594/job/77247980413#step:2:65
This is also documented in https://github.com/actions/checkout:
Changes
${{ github.ref_name }}- this should be, on the schedule action, the default branch (heremaster). This way we should get the latest commit (since it is already pushed to master).