From ee275168a3c7cf472d7aee3804983c797489f792 Mon Sep 17 00:00:00 2001 From: Mossa Date: Tue, 30 Jun 2026 18:57:44 +0200 Subject: [PATCH] fix: use version suffix instead of bool in bindings fallback messages `retrieve_prebuild_bindings` interpolated `version_info.devel` (a `bool`) into its warning and panic where the `-devel`/`""` suffix belonged, so the messages printed nonsense such as "These may not work for R 4.6.0false." Compute the same `devel_suffix` already used by `get_r_bindings_filename` and use it in both messages. Co-Authored-By: Claude Opus 4.8 --- build.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/build.rs b/build.rs index edbb34b6..d12b5276 100644 --- a/build.rs +++ b/build.rs @@ -338,18 +338,19 @@ fn retrieve_prebuild_bindings(version_info: &RVersionInfo) { let bindings_file_full = version_info.get_r_bindings_filename(&target_os, &target_arch); let bindings_file_novers = PathBuf::from(format!("bindings-{target_os}-{target_arch}.rs")); + let devel_suffix = if version_info.devel { "-devel" } else { "" }; let mut from = bindings_path.join(bindings_file_full); if !from.exists() { from = bindings_path.join(bindings_file_novers); if !from.exists() { panic!( "Cannot find libR-sys bindings file for R {}.{}.{}{} on {} in {}. Consider compiling with --features use-bindgen.", - version_info.major, version_info.minor, version_info.patch, version_info.devel, target_os, bindings_path.display() + version_info.major, version_info.minor, version_info.patch, devel_suffix, target_os, bindings_path.display() ) } else { println!( "cargo:warning=using generic {}-{} libR-sys bindings. These may not work for R {}.{}.{}{}.", - target_os, target_arch, version_info.major, version_info.minor, version_info.patch, version_info.devel + target_os, target_arch, version_info.major, version_info.minor, version_info.patch, devel_suffix ); } }