Polish saved views and filters#2241
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands saved views to preserve table sort and structured/hidden filter state, moves view-related controls into a consolidated menu, refreshes saved-view cache invalidation behavior, and adds supporting backend/API/test/package/script updates.
Changes:
- Adds
sortto saved-view backend models, DTOs, generated client types, API validation, mapping tests, and HTTP samples. - Updates Events/Issues/Stream UI to use saved-view titles, serialize filter definitions, consolidate view/column controls, and support hidden filters.
- Delays saved-view websocket invalidations, bumps Aspire package versions, and adds a Kibana dashboard creation script.
Reviewed changes
Copilot reviewed 49 out of 51 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/copilot-setup-steps.yml |
Bumps Aspire CLI setup version. |
k8s/create-kibana-dashboard.ps1 |
Adds Kibana dashboard creation automation. |
src/Exceptionless.AppHost/Exceptionless.AppHost.csproj |
Bumps Aspire AppHost/hosting package versions. |
src/Exceptionless.Core/Models/SavedView.cs |
Adds persisted saved-view sort field. |
src/Exceptionless.Web/Controllers/SavedViewController.cs |
Adds PATCH length validation for sort. |
src/Exceptionless.Web/Models/SavedView/NewSavedView.cs |
Adds sort to create DTO. |
src/Exceptionless.Web/Models/SavedView/UpdateSavedView.cs |
Adds sort to update DTO. |
src/Exceptionless.Web/Models/SavedView/ViewSavedView.cs |
Adds sort to view DTO. |
src/Exceptionless.Web/ClientApp/src/lib/generated/api.ts |
Adds sort to generated saved-view interfaces. |
src/Exceptionless.Web/ClientApp/src/lib/generated/schemas.ts |
Adds sort to generated saved-view schemas. |
src/Exceptionless.Web/ClientApp/src/lib/features/shared/table.svelte.ts |
Synchronizes TanStack sorting state with query sort. |
src/Exceptionless.Web/ClientApp/src/lib/features/shared/components/faceted-filter/* |
Adds hidden-filter state/actions and adjusts filter builder layout. |
src/Exceptionless.Web/ClientApp/src/lib/features/events/components/filters/* |
Propagates hidden-filter state through event filter models, UI wrappers, serialization, and tests. |
src/Exceptionless.Web/ClientApp/src/lib/features/saved-views/api.svelte.ts |
Delays add/save websocket invalidations and syncs created views with explicit organization id. |
src/Exceptionless.Web/ClientApp/src/lib/features/saved-views/use-saved-views.svelte.ts |
Adds sort query support and filter-definition dirty checking. |
src/Exceptionless.Web/ClientApp/src/lib/features/saved-views/use-saved-views.test.ts |
Adds sort/cache invalidation coverage. |
src/Exceptionless.Web/ClientApp/src/lib/features/saved-views/components/saved-view-picker.svelte |
Reworks saved-view menu and folds column visibility into it. |
src/Exceptionless.Web/ClientApp/src/routes/(app)/+page.svelte |
Adds Events sort query wiring, saved-view title, filter serialization, and View menu integration. |
src/Exceptionless.Web/ClientApp/src/routes/(app)/issues/+page.svelte |
Adds Issues sort query wiring, saved-view title, filter serialization, and View menu integration. |
src/Exceptionless.Web/ClientApp/src/routes/(app)/stream/+page.svelte |
Adds Stream saved-view title, filter serialization, and View menu integration. |
src/Exceptionless.Web/ClientApp/src/routes/(app)/+layout.svelte |
Includes saved-view sort in sidebar links. |
src/Exceptionless.Web/ClientApp/src/routes/(app)/(components)/layouts/sidebar.svelte |
Updates settings active-route detection. |
src/Exceptionless.Web/ClientApp/src/routes/(app)/organization/list/+page.svelte |
Removes organization-list helper text. |
tests/Exceptionless.Tests/Controllers/SavedViewControllerTests.cs |
Adds saved-view sort create/update/validation coverage. |
tests/Exceptionless.Tests/Controllers/Data/openapi.json |
Updates OpenAPI fixture for saved-view sort. |
tests/Exceptionless.Tests/Mapping/SavedViewMapperTests.cs |
Adds saved-view sort mapping assertions. |
tests/Exceptionless.Tests/Exceptionless.Tests.csproj |
Bumps Aspire testing package version. |
tests/http/saved-views.http |
Adds sort examples to saved-view HTTP samples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
niemyjski
pushed a commit
that referenced
this pull request
May 19, 2026
* Polish saved views and filters * Fix faceted filter formatting * Fix client lint issues * Update OpenAPI saved view sort baseline * Address saved view PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run buildnpm run checknpm run test:unit -- src/lib/features/saved-views/use-saved-views.test.ts --rundotnet test tests/Exceptionless.Tests/Exceptionless.Tests.csproj -- --filter-class Exceptionless.Tests.Mapping.SavedViewMapperTestsdotnet test tests/Exceptionless.Tests/Exceptionless.Tests.csproj -- --filter-class Exceptionless.Tests.Controllers.SavedViewControllerTests