Skip to content

Commit dff19e5

Browse files
etrclaude
andcommitted
TASK-007 review: broaden HYGIENE_STAMP deps to include Makefile.am and consumer TU
After editing HEADER_HYGIENE_FORBIDDEN or consumer_umbrella_no_backend.cpp, the stamp should be invalidated so check-hygiene re-stages the install. Addresses item 43 from the TASK-007 review. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 477a06f commit dff19e5

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

Makefile.am

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,8 +242,12 @@ HYGIENE_STAMP = $(CHECK_HYGIENE_STAGE)/.hygiene-stamp
242242

243243
# NOTE: wildcard is evaluated at parse time; run `make clean` if new headers
244244
# are added to src/httpserver/ in the same invocation that generates them.
245-
# Also includes the top-level umbrella so a change there invalidates the stamp.
246-
$(HYGIENE_STAMP): $(wildcard $(top_srcdir)/src/httpserver/*.hpp) $(top_srcdir)/src/httpserver.hpp
245+
# Makefile.am and consumer_umbrella_no_backend.cpp are also listed so that
246+
# changes to HEADER_HYGIENE_FORBIDDEN or the consumer TU invalidate the stamp.
247+
$(HYGIENE_STAMP): $(wildcard $(top_srcdir)/src/httpserver/*.hpp) \
248+
$(top_srcdir)/src/httpserver.hpp \
249+
$(top_srcdir)/Makefile.am \
250+
$(top_srcdir)/test/headers/consumer_umbrella_no_backend.cpp
247251
@rm -rf $(CHECK_HYGIENE_STAGE)
248252
@$(MAKE) $(AM_MAKEFLAGS) install DESTDIR=$(CHECK_HYGIENE_STAGE) >check-hygiene-install.log 2>&1 || { \
249253
echo "FAIL: staged install failed"; cat check-hygiene-install.log; \

0 commit comments

Comments
 (0)