Skip to content

Commit 639615c

Browse files
etrclaude
andcommitted
CI: revert helgrind --history-level=full (ineffective)
--history-level=full did not reduce the helgrind race reports (still 84 FAIL, identical frames). Root cause: MHD signals its worker thread via an internal ITC pipe, not a pthread primitive, so NO helgrind history level can observe that happens-before — the reports are inherent to MHD's design, not an approx-history artifact. Revert to the ax_valgrind_check default (approx, faster). The valgrind lanes will be addressed with third-party suppressions instead (tracked separately). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpysYDDJac63yz2mZKKiDf
1 parent c435774 commit 639615c

1 file changed

Lines changed: 1 addition & 13 deletions

File tree

.github/workflows/verify-build.yml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1395,19 +1395,7 @@ jobs:
13951395
run: |
13961396
cd build ;
13971397
TOOL="${BUILD_TYPE#valgrind-}" ;
1398-
# Override ax_valgrind_check's --history-level=approx default for
1399-
# helgrind. approx drops the happens-before history, so helgrind can't
1400-
# see the synchronisation MHD_start_daemon()'s pthread_create
1401-
# establishes between the main thread's pre-start setup and the worker
1402-
# threads reading that immutable-after-start state during dispatch,
1403-
# producing a flood of benign "data race" reports on libhttpserver
1404-
# frames whose conflicting access was "the start of the thread". full
1405-
# tracks the complete graph and proves those reads ordered, removing
1406-
# the false positives at the source (no libhttpserver-frame suppression,
1407-
# per DR-008). A make command-line assignment overrides the Makefile's
1408-
# ?= default and propagates to the recursive check-TESTS make; it is
1409-
# inert for the memcheck/drd tools that don't consume it.
1410-
make VALGRIND_helgrind_FLAGS=--history-level=full "check-valgrind-${TOOL}" ;
1398+
make "check-valgrind-${TOOL}" ;
14111399
if: ${{ startsWith(matrix.build-type, 'valgrind-') }}
14121400

14131401
- name: Print Valgrind results

0 commit comments

Comments
 (0)