Center camera on player when dialogue balloon appears#2240
Draft
manuq wants to merge 2 commits into
Draft
Conversation
Remove scale from foam tilemap layer. Remove 8 pixels vertical offset from the Node2D that contains all tilemap layers. Adjust OnTheGround nodes accordingly.
Collaborator
Author
|
This is hardcoded for now, just for testing: Grabacion.de.pantalla.desde.2026-05-22.16-19-32.mp4What about a bit of zoom? Grabacion.de.pantalla.desde.2026-05-22.16-18-43.mp4Again this brings the issue of having to pass the world limits between cameras. And I think that if the limit is at the west (case of Lore elder) then the balloon should appear at the top-right corner, and the camera should shift to the other side. |
|
Play this branch at https://play.threadbare.game/branches/endlessm/dialogue-camera/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.