Fray's End: Small fix for positions and scales#2239
Open
manuq wants to merge 1 commit into
Open
Conversation
Remove scale from foam tilemap layer. Remove 8 pixels vertical offset from the Node2D that contains all tilemap layers. Adjust OnTheGround nodes accordingly.
Collaborator
Author
|
I checked by taking screenshots and comparing with GIMP that the before/after positions are the same. The reason I had to do it is because I was trying to set the camera limits to the Water tilemap layer (with PhantomCamera2D). And found that it had a 8 pixels offset! |
|
Play this branch at https://play.threadbare.game/branches/endlessm/frays-end-fixes/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove scale from foam tilemap layer.
Remove 8 pixels vertical offset from the Node2D that contains all tilemap layers. Adjust OnTheGround nodes accordingly.