Httpx is not encoding "%" symbol while sending requests

[heysarthak]

Hi team,

I am ussing httpx plugin, while sending httpx query "ngi%abc.com" .
ideally "%" symbol should be encoded as "%25" but it is still sending as the same "%".

can we please have a fix for this.

[lovelydinosaur]

Could you be more specific and demonstrate the actual code?

[heysarthak]

Hi @tomchristie ,
do you need more details?
was i able to answer your question?

thanks

[heysarthak]

Hi @tomchristie,

Should i move it to a bug?

[lovelydinosaur]

Hmmm, so the URL https://www.example.com/test%this doesn't need escaping.

(Eg. if you try pasting it into a browser bar it'll be sent as-is, unlike https://www.example.com/test this)

[heysarthak]

the url <>.ats-ravi/nudr-dr-prov/v2/policy-data/nai-eng%nai2@example.net SHOULD BE SENT AS
http://<>.ats-ravi/nudr-dr-prov/v2/policy-data/nai-eng%25nai2@example.net

if you write on google "searching for %"

the query that is sent is "https://www.google.com/search?q=searching+for+%25"
where % is being encoded as %25

But this is not happening with this release of package. v0.24.0+

it used to work with
[Version 0.23.3]

[heysarthak]

@tomchristie do you have any solution to this?

[gyanu2507]

httpx treats % in a URL as already percent-encoded, so ngi%abc.com goes out with a literal %. That matches RFC 3986 (a % starts an escape). Requests has the same idea in most cases.

If you want the byte % on the wire as %25:

from urllib.parse import quote

httpx.get("https://example.com/search", params={"q": "ngi%abc.com"})
# params are encoded, so this becomes q=ngi%25abc.com

# for a path segment:
path = quote("ngi%abc.com", safe="")
httpx.get(f"https://example.com/{path}")

Do not put a raw % in a path string and expect httpx to guess. Tom asked for a snippet of the actual call. If you paste that, we can say whether it is path, query, or a raw URL.