From 95dd562f801204e6cbce876508ad40bd35f54823 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Tue, 21 Apr 2026 16:55:04 -0700 Subject: [PATCH] Remove redundant error checking from libpthread/libwasm_worker As the error states this limitation is already enforced by the feature matrix (using `Feature.WORKER_ES6_MODULES`). Duplicating the information already present in the feature matix kind of defeats the whole purpose of the feature matrix (i.e. a centralized place to store this info) and creates scope for skew. See #26677. --- src/lib/libpthread.js | 3 --- src/lib/libwasm_worker.js | 3 --- 2 files changed, 6 deletions(-) diff --git a/src/lib/libpthread.js b/src/lib/libpthread.js index cb6497e53eac0..5c1c7a20426ca 100644 --- a/src/lib/libpthread.js +++ b/src/lib/libpthread.js @@ -22,9 +22,6 @@ #if EVAL_CTORS #error "EVAL_CTORS is not compatible with pthreads yet (passive segments)" #endif -#if EXPORT_ES6 && (MIN_FIREFOX_VERSION < 114 || MIN_CHROME_VERSION < 80 || MIN_SAFARI_VERSION < 150000) -#error "internal error, feature_matrix should not allow this" -#endif {{{ #if MEMORY64 diff --git a/src/lib/libwasm_worker.js b/src/lib/libwasm_worker.js index 88787a7947712..ba0688f1b0b36 100644 --- a/src/lib/libwasm_worker.js +++ b/src/lib/libwasm_worker.js @@ -18,9 +18,6 @@ #if WASM2JS && MODULARIZE #error "-sWASM=0 + -sMODULARIZE + -sWASM_WORKERS is not supported" #endif -#if EXPORT_ES6 && (MIN_FIREFOX_VERSION < 114 || MIN_CHROME_VERSION < 80 || MIN_SAFARI_VERSION < 150000) -#error "internal error, feature_matrix should not allow this" -#endif #endif // ~WASM_WORKERS