(sync-service) queryable_columns to only restrict columns changeable by the client#4534
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4534 +/- ##
==========================================
- Coverage 56.46% 56.44% -0.02%
==========================================
Files 358 358
Lines 39081 39081
Branches 10978 10975 -3
==========================================
- Hits 22066 22061 -5
- Misses 16944 16948 +4
- Partials 71 72 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
robacourt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #4531 made
queryable_columnsapply to normal shapewhereclauses, but as #4531 (comment) pointed out, sensitive columns could still be accessed via subqueries. Making arbitrarywhereclauses with subqueries secure would require more than a root-table column allow-list: we would also need a table allow-list plus per-tablequeryable_columnsfor every table referenced by a subquery.However, normal where clauses are supposed to be restricted and only set server-side. There's no need to restrict them at all. The are to restrict is the subset snapshots, where clients can change subset
whereandorder_by.This PR makes the behavior consistent by allowing any server-defined main
whereclause while keepingqueryable_columnsenforcement for subsetwhereand subsetorder_by. It also updates the docs to make this distinction clear too.Summary
whereclauses to reference any table column even whenqueryable_columnsis setqueryable_columnsenforcement for synced projections, subsetwhere, and subsetorder_by