Use OSGI debug tracing in org.eclipse.ui.workbench

[trancexpress]

See org.eclipse.ui.internal.misc.Policy: https://github.com/eclipse-platform/eclipse.platform.ui/blob/master/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/misc/Policy.java

The debug flags defined there delegate to:

• org.eclipse.ui.internal.WorkbenchPlugin.log(String, Throwable)
• org.eclipse.core.commands.internal.util.Tracing.printTrace(String, String)

This mainly has the problem of not including most information available in OSGI tracing, such as current thread, calling method and so on.

See this for an example on what we should instead do: org.eclipse.core.internal.jobs.JobManager.DEBUG_TRACE

[trancexpress]

@iloveeclipse any idea how those tracing options can be enabled?

		if (getDebugOption("/debug")) { //$NON-NLS-1$
			DEBUG_SWT_GRAPHICS = getDebugOption("/trace/graphics"); //$NON-NLS-1$
			DEBUG_SWT_DEBUG = getDebugOption("/debug/swtdebug"); //$NON-NLS-1$
			DEBUG_SWT_DEBUG_GLOBAL = getDebugOption("/debug/swtdebugglobal"); //$NON-NLS-1$
			DEBUG_DRAG_DROP = getDebugOption("/trace/dragDrop"); //$NON-NLS-1$
			DEBUG_SOURCES = getDebugOption("/trace/sources"); //$NON-NLS-1$
			DEBUG_KEY_BINDINGS = getDebugOption("/trace/keyBindings"); //$NON-NLS-1$
			DEBUG_KEY_BINDINGS_VERBOSE = getDebugOption("/trace/keyBindings.verbose"); //$NON-NLS-1$
			DEBUG_TOOLBAR_DISPOSAL = "true" //$NON-NLS-1$
					.equalsIgnoreCase(Platform.getDebugOption("org.eclipse.jface/trace/toolbarDisposal")); //$NON-NLS-1$
			DEBUG_COMMANDS = getDebugOption("/trace/commands"); //$NON-NLS-1$
			DEBUG_CONTEXTS = getDebugOption("/trace/contexts"); //$NON-NLS-1$
			DEBUG_CONTEXTS_PERFORMANCE = getDebugOption("/trace/contexts.performance"); //$NON-NLS-1$
			DEBUG_CONTEXTS_VERBOSE = getDebugOption("/trace/contexts.verbose"); //$NON-NLS-1$
			DEBUG_HANDLERS = getDebugOption("/trace/handlers"); //$NON-NLS-1$
			DEBUG_HANDLERS_PERFORMANCE = getDebugOption("/trace/handlers.performance"); //$NON-NLS-1$
			DEBUG_HANDLERS_VERBOSE = getDebugOption("/trace/handlers.verbose"); //$NON-NLS-1$
			DEBUG_OPERATIONS = getDebugOption("/trace/operations"); //$NON-NLS-1$
			DEBUG_OPERATIONS_VERBOSE = getDebugOption("/trace/operations.verbose"); //$NON-NLS-1$
			DEBUG_SHOW_ALL_JOBS = getDebugOption("/debug/showAllJobs"); //$NON-NLS-1$
			DEBUG_STALE_JOBS = getDebugOption("/debug/job.stale"); //$NON-NLS-1$
			DEBUG_HANDLERS_VERBOSE_COMMAND_ID = Platform
					.getDebugOption(PlatformUI.PLUGIN_ID + "/trace/handlers.verbose.commandId"); //$NON-NLS-1$
			if ("".equals(DEBUG_HANDLERS_VERBOSE_COMMAND_ID)) { //$NON-NLS-1$
				DEBUG_HANDLERS_VERBOSE_COMMAND_ID = null;
			}
			DEBUG_DECLARED_IMAGES = getDebugOption("/debug/declaredImages"); //$NON-NLS-1$
			DEBUG_CONTRIBUTIONS = getDebugOption("/debug/contributions"); //$NON-NLS-1$
			EXPERIMENTAL_MENU = getDebugOption("/experimental/menus"); //$NON-NLS-1$
			DEBUG_MPE = getDebugOption("/trace/multipageeditor"); //$NON-NLS-1$
			DEBUG_WORKING_SETS = getDebugOption("/debug/workingSets"); //$NON-NLS-1$

I'm not finding anything about them in the tracing preference page, also they aren't contained in the .options of org.eclipse.ui.workbench.

[trancexpress]

Also note that org.eclipse.core.commands.internal.util.Tracing is marked deprecated for removal.