Many C++ compilation errors

[yurivict]

Clang-21 fails to compile it with these errors:

FreeBSD clang version 21.1.8 (https://github.com/llvm/llvm-project.git llvmorg-21.1.8-0-g2078da43e25a)
Target: x86_64-unknown-freebsd15.1
Thread model: posix
InstalledDir: /usr/bin
[yuri@yv /usr/ports/science/py-dwave-optimization]$ make
===>  Building for py312-dwave-optimization-0.7.2
* Getting build dependencies for wheel...
* Building wheel...
+ meson setup /usr/ports/science/py-dwave-optimization/work-py312/dwave_optimization-0.7.2 /usr/ports/science/py-dwave-optimization/work-py312/dwave_optimization-0.7.2/.mesonpy-rla_miai -Dbuildtype=release -Db_ndebug=if-release -Db_vscrt=md --native-file=/usr/ports/science/py-dwave-optimization/work-py312/dwave_optimization-0.7.2/.mesonpy-rla_miai/meson-python-native-file.ini
The Meson build system
Version: 1.11.2
Source dir: /usr/ports/science/py-dwave-optimization/work-py312/dwave_optimization-0.7.2
Build dir: /usr/ports/science/py-dwave-optimization/work-py312/dwave_optimization-0.7.2/.mesonpy-rla_miai
Build type: native build
Project name: dwave-optimization
Project version: 0.7.2

C compiler for the host machine: cc (clang 21.1.8 "FreeBSD clang version 21.1.8 (https://github.com/llvm/llvm-project.git llvmorg-21.1.8-0-g2078da43e25a)")
C linker for the host machine: cc ld.lld 21.1.8
C++ compiler for the host machine: c++ (clang 21.1.8 "FreeBSD clang version 21.1.8 (https://github.com/llvm/llvm-project.git llvmorg-21.1.8-0-g2078da43e25a)")
C++ linker for the host machine: c++ ld.lld 21.1.8
Cython compiler for the host machine: cython (cython 3.2.8)
Host machine cpu family: x86_64
Host machine cpu: x86_64
Program python found: YES (/usr/local/bin/python3.12)
Found pkg-config: YES (/usr/local/bin/pkg-config) 2.4.3
Run-time dependency python found: YES 3.12
Build targets in project: 26

dwave-optimization 0.7.2


  User defined options
    Native files: /usr/ports/science/py-dwave-optimization/work-py312/dwave_optimization-0.7.2/.mesonpy-rla_miai/meson-python-native-file.ini
    b_ndebug    : if-release
    b_vscrt     : md
    buildtype   : release

Found ninja-1.13.2 at /usr/local/bin/ninja
+ /usr/local/bin/ninja                                                                                                                                                                     
[7/103] Compiling C++ object libdwave-optimization.so.p/dwave_optimization_src_nodes_lp.cpp.o
FAILED: [code=1] libdwave-optimization.so.p/dwave_optimization_src_nodes_lp.cpp.o 
c++ -Ilibdwave-optimization.so.p -I. -I.. -I../dwave/optimization/include -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c++20 -O3 -g1 -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=2 -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -MD -MQ libdwave-optimization.so.p/dwave_optimization_src_nodes_lp.cpp.o -MF libdwave-optimization.so.p/dwave_optimization_src_nodes_lp.cpp.o.d -o libdwave-optimization.so.p/dwave_optimization_src_nodes_lp.cpp.o -c ../dwave/optimization/src/nodes/lp.cpp
../dwave/optimization/src/nodes/lp.cpp:26:28: error: definition of implicitly declared destructor
   26 | LinearProgramFeasibleNode::~LinearProgramFeasibleNode() = default;
      |                            ^
../dwave/optimization/src/nodes/lp.cpp:27:24: error: definition of implicitly declared destructor
   27 | LinearProgramNodeBase::~LinearProgramNodeBase() = default;
      |                        ^
../dwave/optimization/src/nodes/lp.cpp:28:20: error: definition of implicitly declared destructor
   28 | LinearProgramNode::~LinearProgramNode() = default;
      |                    ^
../dwave/optimization/src/nodes/lp.cpp:29:34: error: definition of implicitly declared destructor
   29 | LinearProgramObjectiveValueNode::~LinearProgramObjectiveValueNode() = default;
      |                                  ^
../dwave/optimization/src/nodes/lp.cpp:30:28: error: definition of implicitly declared destructor
   30 | LinearProgramSolutionNode::~LinearProgramSolutionNode() = default;
      |                            ^
5 errors generated.
[10/103] Compiling C++ object libdwave-optimization.so.p/dwave_optimization_src_graph.cpp.o
FAILED: [code=1] libdwave-optimization.so.p/dwave_optimization_src_graph.cpp.o 
c++ -Ilibdwave-optimization.so.p -I. -I.. -I../dwave/optimization/include -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c++20 -O3 -g1 -D_LIBCPP_TYPEINFO_COMPARISON_IMPLEMENTATION=2 -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -MD -MQ libdwave-optimization.so.p/dwave_optimization_src_graph.cpp.o -MF libdwave-optimization.so.p/dwave_optimization_src_graph.cpp.o.d -o libdwave-optimization.so.p/dwave_optimization_src_graph.cpp.o -c ../dwave/optimization/src/graph.cpp
../dwave/optimization/src/graph.cpp:36:7: error: redefinition of '~Node'
   36 | Node::~Node() { *expired_ptr_ = true; }
      |       ^
../dwave/optimization/include/dwave-optimization/graph.hpp:257:13: note: previous definition is here
  257 |     virtual ~Node() { *expired_ptr_ = true; }
      |             ^
../dwave/optimization/src/graph.cpp:37:8: error: definition of implicitly declared destructor
   37 | Array::~Array() = default;
      |        ^
../dwave/optimization/src/graph.cpp:38:12: error: definition of implicitly declared destructor
   38 | ArrayNode::~ArrayNode() = default;
      |            ^
3 errors generated.

Version: 0.7.2
FreeBSD 15.1

[arcondello]

I am unable to reproduce. Further, the error messages confuse me.

../dwave/optimization/src/graph.cpp:36:7: error: redefinition of '~Node'
   36 | Node::~Node() { *expired_ptr_ = true; }

doesn't seem to correspond to line 36 of graph.cpp

dwave-optimization/dwave/optimization/src/graph.cpp

Line 36 in 3b95330

void Graph::add_constraint(ArrayNode* constraint_ptr) {

Likewise for the LinearProgramNode errors.