From 2bedac6ce605aaf8a00d93a0833f86a0c3395b52 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Dinis=20Ferreira?= <hello@joaof.eu>
Date: Sun, 31 May 2026 14:36:07 +0200
Subject: [PATCH] fix: remove duplicate spotbugs <maxHeap> (resurrect
 spotbugs.maxHeap=2048)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The spotbugs-maven-plugin <configuration> declared <maxHeap> twice: first
${spotbugs.maxHeap} (2048), then a hardcoded <maxHeap>1024</maxHeap> that
silently overrode it — so the spotbugs.maxHeap property was dead and the
effective per-analysis (forked) heap was 1 GB, not the intended 2 GB. Remove
the stray override so the property takes effect.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 ddk-parent/pom.xml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/ddk-parent/pom.xml b/ddk-parent/pom.xml
index 491a7ab04..ecbbaa1ac 100644
--- a/ddk-parent/pom.xml
+++ b/ddk-parent/pom.xml
@@ -401,11 +401,14 @@
         </dependencies>
         <configuration>
           <failOnError>true</failOnError>
+          <!-- Per-analysis (forked) heap. A second <maxHeap>1024</maxHeap> used to follow and
+               silently override this, leaving spotbugs.maxHeap (2048) dead; removed. NOTE: under
+               -T 2C a full scan can run up to ~8 forks concurrently (~8x2G + maven 4G ~ 20G > the
+               16G runner) — if the full-scan spotbugs job OOMs, lower this or the reactor thread count. -->
           <maxHeap>${spotbugs.maxHeap}</maxHeap>
           <maxRank>15</maxRank>
           <threshold>Low</threshold>
           <excludeFilterFile>${spotbugs.excludeFilterFile}</excludeFilterFile>
-          <maxHeap>1024</maxHeap>
         </configuration>
       </plugin>
     </plugins>