From da7980789c31b97e30b63943f697ea137a267cd0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Dinis=20Ferreira?= Date: Sat, 30 May 2026 18:01:02 +0200 Subject: [PATCH] fix: always log the null-marker-creator error, not only when debug is enabled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CheckMarkerUpdateJob logged "Could not create markers. The marker creator is null." at ERROR level but only inside `if (LOGGER.isDebugEnabled())`, so in production (debug off) a genuine failure to create markers was silent. Remove the isDebugEnabled guard — isDebugEnabled is for gating expensive debug/trace output, not real errors. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../ddk/check/runtime/ui/validation/CheckMarkerUpdateJob.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/com.avaloq.tools.ddk.check.runtime.ui/src/com/avaloq/tools/ddk/check/runtime/ui/validation/CheckMarkerUpdateJob.java b/com.avaloq.tools.ddk.check.runtime.ui/src/com/avaloq/tools/ddk/check/runtime/ui/validation/CheckMarkerUpdateJob.java index c266fa1de..5292231ba 100644 --- a/com.avaloq.tools.ddk.check.runtime.ui/src/com/avaloq/tools/ddk/check/runtime/ui/validation/CheckMarkerUpdateJob.java +++ b/com.avaloq.tools.ddk.check.runtime.ui/src/com/avaloq/tools/ddk/check/runtime/ui/validation/CheckMarkerUpdateJob.java @@ -236,9 +236,7 @@ private void createMarkers(final MarkerCreator markerCreator, final IFile file, markerCreator.createMarker(issue, file, MarkerTypes.forCheckType(issue.getType())); } } else { - if (LOGGER.isDebugEnabled()) { - LOGGER.error("Could not create markers. The marker creator is null."); //$NON-NLS-1$ - } + LOGGER.error("Could not create markers. The marker creator is null."); //$NON-NLS-1$ } }