More thorough check of framework description for .NET 6+ - #12308
Merged
Conversation
Found a bug where the frameworkDescription wasn't simply ".NET" but instead was ".NET" with additional version information. This requires we check beyond just a simple compare.
Chagrins
requested review from
jonathanpeppers and
simonrozsival
as code owners
August 6, 2026 23:33
Member
|
/review |
Contributor
|
✅ Android PR Reviewer completed successfully! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Needs Changes
Findings: 0 errors · 0 warnings · 1 suggestion
The runtime-version check correctly preserves LibZipSharp for .NET Framework/legacy Mono while allowing System.IO.Compression on .NET 6+. The implementation is appropriately minimal. CI is still in progress (completed checks are passing), so this is not yet ready for a green verdict.
Generated by Android PR Reviewer for #12308 · gpt56 · 53.5 AIC · ⌖ 9.98 AIC · ⊞ 25.3K
Comment /review to run again
jonathanpeppers
added
the
ready-to-review
dalexsoto
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Xamarin.Android.Build.Tasks] Issue where
frameworkDescriptionwasn't simply ".NET" but instead was ".NET" with additional version information. This requires we check beyond just a simple compare.Pull Request
title and
description
should follow the
commit-messages.mdworkflow documentation, and in particular should include: