docs: Add external property back to compose and add swarm secrets example using compose - #25522
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks @deahtstroke. The Could you drop the |
d157f0e to
7c21659
Compare
…xample using compose
7c21659 to
0d0e6f6
Compare
|
Thanks for the Review! Yeah I hard agree on that rationale, which also makes sense as to why the original issues about the external option being confusing for compose users were opened in the first place. I removed the changes to |
Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
aevesdocker
left a comment
There was a problem hiding this comment.
Thank you @deahtstroke!
Description
Added back the attribute
externalin the/reference/compose/secretssection with a warning that this attribute is only available for Docker Swarm. Additionally, I added a small toy reference example to the section "Defining and using Secrets in compose files" and moved the section outside of the "Examples" section. The reason why I did this is because I noticed the Examples are all runnable steps that showcase concrete usage of secrets, the example I added is just a skeleton/reference to how they should be used in conjunction withdocker secret create..., not a true able-to-run example like the ones below. I also changed the hyperlink from/reference/compose-file/legacy-versions.mdto/reference/compose-file/secrets.md.A few caveats that I wasn't sure about when writing this:
Edit:
I'm also not opposed to making a fully working example using compose, stack and secrets and putting the section back under
ExamplesRelated issues or tickets
#25491
Reviews