Merge pull request #7 from moropo-com/fix/tsconfig-strict

fix: enable TypeScript strict mode and type-check tests in CI

Author: riglar

.github/workflows/cli-ci.yml

@@ -58,6 +58,10 @@ jobs:
       working-directory: ./cli
       run: pnpm lint
 
+    - name: Type check (strict, src + tests)
+      working-directory: ./cli
+      run: pnpm typecheck
+
     - name: Run CLI tests
       working-directory: ./cli
       env:

CLAUDE.md

@@ -6,7 +6,8 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 - `pnpm dcd <args>` — run the CLI from source via `tsx`.
 - `pnpm build` — clean, compile TypeScript to `dist/`, and `chmod +x dist/index.js` so the published binary is directly executable.
-- `pnpm lint` — ESLint over `src/`.
+- `pnpm lint` — ESLint over `src/` and `test/`.
+- `pnpm typecheck` — `tsc --noEmit` over `src/` and `test/` (strict mode; `pnpm build` only compiles `src/`).
 - `pnpm test` — runs `scripts/test-runner.mjs`: builds the CLI, boots a mock API, then runs all `test/**/*.test.ts` via mocha + ts-node. The mock API lives in the **sibling `dcd/` repo** (`../dcd/mock-api`). Override its location with `MOCK_API_DIR=/path/to/mock-api`.
 - Run a single test: `pnpm mocha test/integration/cloud.integration.test.ts --timeout 60000` (picks up `.mocharc.json` which wires tsx; requires the mock API already running on its expected port).
 

eslint.config.js

@@ -74,4 +74,12 @@ module.exports = tseslint.config(
       '@typescript-eslint/no-require-imports': 'off',
     },
   },
+  {
+    // Chai's property-style assertions (`expect(x).to.be.true`) are
+    // expression statements by design.
+    files: ['test/**/*.ts'],
+    rules: {
+      '@typescript-eslint/no-unused-expressions': 'off',
+    },
+  },
 );

package.json

@@ -60,9 +60,10 @@
     "dcd": "tsx src/index.ts",
     "build": "shx rm -rf dist && tsc -b && shx chmod +x dist/index.js",
     "build:binaries": "node scripts/build-binaries.mjs",
-    "lint": "eslint src --ext .ts",
+    "lint": "eslint src test --ext .ts",
     "prepare": "pnpm build",
-    "test": "node scripts/test-runner.mjs"
+    "test": "node scripts/test-runner.mjs",
+    "typecheck": "tsc --noEmit -p tsconfig.test.json"
   },
   "version": "5.0.0",
   "bugs": {

src/commands/upgrade.ts

@@ -131,7 +131,10 @@ async function downloadToFile(url: string, dest: string): Promise<void> {
     throw new Error(`HTTP ${res.status} fetching ${url}`);
   }
   // Node 22 exposes Readable.fromWeb for piping a WHATWG ReadableStream.
-  await pipeline(Readable.fromWeb(res.body), createWriteStream(dest));
+  await pipeline(
+    Readable.fromWeb(res.body as Parameters<typeof Readable.fromWeb>[0]),
+    createWriteStream(dest),
+  );
 }
 
 async function fetchExpectedChecksum(

src/services/results-polling.service.ts

@@ -8,8 +8,9 @@ import { checkInternetConnectivity } from '../utils/connectivity';
 import { ux } from '../utils/progress';
 import { colors, formatTestSummary, table } from '../utils/styling';
 
-type TestResult =
-  paths['/results/{uploadId}']['get']['responses']['200']['content']['application/json']['results'][number];
+type TestResult = NonNullable<
+  paths['/results/{uploadId}']['get']['responses']['200']['content']['application/json']['results']
+>[number];
 
 /**
  * Custom error for run failures that includes the polling result
@@ -177,7 +178,7 @@ export class ResultsPollingService {
         ? 'PASSED'
         : 'FAILED',
       tests: resultsWithoutEarlierTries.map((r) => ({
-        durationSeconds: r.duration_seconds,
+        durationSeconds: r.duration_seconds ?? null,
         failReason:
           r.status === 'FAILED' ? r.fail_reason || 'No reason provided' : undefined,
         fileName: r.test_file_name,

src/services/version.service.ts

@@ -92,6 +92,12 @@ export class VersionService {
       }
     }
 
+    if (!resolvedVersion) {
+      throw new Error(
+        'Unable to resolve a Maestro version: compatibility data did not provide a default.',
+      );
+    }
+
     // Validate Maestro version
     if (!supportedVersions.includes(resolvedVersion)) {
       throw new Error(

tsconfig.json

@@ -4,10 +4,11 @@
     "module": "commonjs",
     "outDir": "dist",
     "rootDir": "src",
-    "strict": false,
+    "strict": true,
     "target": "es2022",
     "skipLibCheck": true,
-    "resolveJsonModule": true
+    "resolveJsonModule": true,
+    "forceConsistentCasingInFileNames": true
   },
   "include": ["src/**/*"]
 }

tsconfig.test.json

@@ -0,0 +1,10 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noEmit": true,
+    "declaration": false,
+    "rootDir": ".",
+    "types": ["node", "mocha", "chai"]
+  },
+  "include": ["src/**/*", "test/**/*"]
+}