Skip to content

ethers-v6: AddressLike in encodeFunctionData is incorrect #890

Description

@olehmisar

encodeFunctionData is a synchronous function, so it cannot resolve AddressLike.
Interfaces functions (encodeFunctionData and others) should accept string instead of AddressLike

This code will throw an error:

declare const alice: Wallet
iface.encodeFunctionData('balanceOf', [alice]);

But this will NOT:

iface.encodeFunctionData('balanceOf', [await alice.getAddress()]);

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions