Skip to content

Commit 0aa256b

Browse files
milanmajchrakclaude
andcommitted
Wire CLARIN distribution-license submission section (S6)
Override SectionsType.License with SubmissionSectionClarinLicenseDistributionComponent (the CLARIN distribution-license variant: ng-toggle acceptance + distribution-license-agreement link + help-desk contact) in sections-decorator.ts, replacing the vanilla checkbox-based SubmissionSectionLicenseComponent. Update the matching e2e specs to interact with the ng-toggle instead of the vanilla #granted checkbox (dtq-dev's exact selector): submission.cy.ts + my-dspace.cy.ts now do `cy.get('ds-clarin-license-distribution ng-toggle').click()`. npm run build = clean (BUILD_EXIT=0); decorator lints clean; no unit specs reference the section map. The toggle interaction is verified by the Cypress e2e (runs in CI against a Docker backend). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent de5ae7c commit 0aa256b

3 files changed

Lines changed: 7 additions & 8 deletions

File tree

cypress/e2e/my-dspace.cy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ describe('My DSpace page', () => {
215215
cy.get('#dc_date_issued_year').type(currentYear.toString());
216216
cy.get('input[name="dc.type"]').click();
217217
cy.get('.dropdown-menu').should('be.visible').contains('button', 'Other').click();
218-
cy.get('#granted').check();
218+
cy.get('ds-clarin-license-distribution ng-toggle').click();
219219

220220
//Press deposit button
221221
cy.get('button[data-test="deposit"]').click();

cypress/e2e/submission.cy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ describe('New Submission page', () => {
125125

126126
// Confirm the required license by checking checkbox
127127
// (NOTE: requires "force:true" cause Cypress claims this checkbox is covered by its own <span>)
128-
cy.get('input#granted').check( { force: true } );
128+
cy.get('ds-clarin-license-distribution ng-toggle').click();
129129

130130
// Before using Cypress drag & drop, we have to manually trigger the "dragover" event.
131131
// This ensures our UI displays the dropzone that covers the entire submission page.

src/app/submission/sections/sections-decorator.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { SubmissionSectionAccessesComponent } from './accesses/section-accesses.component';
22
import { SubmissionSectionCcLicensesComponent } from './cc-license/submission-section-cc-licenses.component';
3+
import { SubmissionSectionClarinLicenseDistributionComponent } from './clarin-license-distribution/clarin-license-distribution.component';
34
import { SubmissionSectionClarinLicenseComponent } from './clarin-license-resource/section-license.component';
45
import { SubmissionSectionClarinNoticeComponent } from './clarin-notice/clarin-notice.component';
56
import { SubmissionSectionDuplicatesComponent } from './duplicates/section-duplicates.component';
67
import { SubmissionSectionFormComponent } from './form/section-form.component';
78
import { SubmissionSectionIdentifiersComponent } from './identifiers/section-identifiers.component';
8-
import { SubmissionSectionLicenseComponent } from './license/section-license.component';
99
import { SubmissionSectionCoarNotifyComponent } from './section-coar-notify/section-coar-notify.component';
1010
import { SectionsType } from './sections-type';
1111
import { SubmissionSectionSherpaPoliciesComponent } from './sherpa-policies/section-sherpa-policies.component';
@@ -14,11 +14,10 @@ import { SubmissionSectionUploadComponent } from './upload/section-upload.compon
1414
const submissionSectionsMap = new Map();
1515

1616
submissionSectionsMap.set(SectionsType.AccessesCondition, SubmissionSectionAccessesComponent);
17-
// NOTE: CLARIN's SubmissionSectionClarinLicenseDistributionComponent (ng-toggle variant) is ported but
18-
// NOT wired to override SectionsType.License here — doing so replaces the vanilla license checkbox
19-
// (#granted) and breaks the vanilla submission/my-dspace e2e specs. Keep the vanilla License component
20-
// active; activating the CLARIN distribution variant requires porting dtq-dev's matching e2e changes too.
21-
submissionSectionsMap.set(SectionsType.License, SubmissionSectionLicenseComponent);
17+
// CLARIN: override the vanilla License section with the distribution-license variant (ng-toggle
18+
// acceptance + help-desk link). The matching e2e specs (submission/my-dspace) interact with the
19+
// ng-toggle (ds-clarin-license-distribution ng-toggle) instead of the vanilla #granted checkbox.
20+
submissionSectionsMap.set(SectionsType.License, SubmissionSectionClarinLicenseDistributionComponent);
2221
submissionSectionsMap.set(SectionsType.CcLicense, SubmissionSectionCcLicensesComponent);
2322
submissionSectionsMap.set(SectionsType.SherpaPolicies, SubmissionSectionSherpaPoliciesComponent);
2423
submissionSectionsMap.set(SectionsType.Upload, SubmissionSectionUploadComponent);

0 commit comments

Comments
 (0)