refactor(gc): rename orphaned_paths -> orphaned_schema_paths for full symmetry

Completes the hash/schema stat-name parallelism: the two orphan-path lists are
now orphaned_hash_paths and orphaned_schema_paths (was the unqualified
orphaned_paths). Keys + internal variable renamed; no behavior change. GC 39/39.

Author: dimitri-yatsenko

src/datajoint/gc.py

@@ -323,7 +323,7 @@ def collect(self, dry_run: bool = True, verbose: bool = False) -> dict[str, Any]
           (NOT bare hashes — passed as-is to the deleter)
         - schema_paths_referenced / schema_paths_stored / schema_paths_orphaned
           / schema_paths_orphaned_bytes
-        - orphaned_paths: orphaned schema files as full relative store paths
+        - orphaned_schema_paths: orphaned schema files as full relative store paths
         - hash_paths_deleted / schema_paths_deleted / deleted / bytes_freed (0 when
           dry_run) / errors / dry_run
         """
@@ -342,7 +342,7 @@ def collect(self, dry_run: bool = True, verbose: bool = False) -> dict[str, Any]
         orphaned_hash_paths = sorted(set(hash_paths_stored.keys()) - hash_paths_referenced)
         # Coverage, not exact set difference: a referenced path may be a
         # directory-valued object (many files + a manifest sidecar).
-        orphaned_paths = sorted(p for p in schema_paths_stored if not _is_covered(p, schema_paths_referenced))
+        orphaned_schema_paths = sorted(p for p in schema_paths_stored if not _is_covered(p, schema_paths_referenced))
 
         hash_paths_deleted = 0
         schema_paths_deleted = 0
@@ -363,7 +363,7 @@ def collect(self, dry_run: bool = True, verbose: bool = False) -> dict[str, Any]
                     errors += 1
                     logger.warning(f"Failed to delete {path}: {e}")
 
-            for path in orphaned_paths:
+            for path in orphaned_schema_paths:
                 try:
                     if self.delete_schema_path(path):
                         schema_paths_deleted += 1
@@ -384,9 +384,9 @@ def collect(self, dry_run: bool = True, verbose: bool = False) -> dict[str, Any]
             # Schema-addressed storage stats
             "schema_paths_referenced": len(schema_paths_referenced),
             "schema_paths_stored": len(schema_paths_stored),
-            "schema_paths_orphaned": len(orphaned_paths),
-            "schema_paths_orphaned_bytes": sum(schema_paths_stored.get(p, 0) for p in orphaned_paths),
-            "orphaned_paths": orphaned_paths,
+            "schema_paths_orphaned": len(orphaned_schema_paths),
+            "schema_paths_orphaned_bytes": sum(schema_paths_stored.get(p, 0) for p in orphaned_schema_paths),
+            "orphaned_schema_paths": orphaned_schema_paths,
             # Deletion outcome (all zero when dry_run)
             "hash_paths_deleted": hash_paths_deleted,
             "schema_paths_deleted": schema_paths_deleted,

tests/integration/test_gc.py

@@ -230,7 +230,7 @@ def test_dry_run_reports_stats_and_deletes_nothing(self):
         # full report is present
         assert stats["hash_paths_orphaned"] == 1 and stats["orphaned_hash_paths"] == ["_hash/s/path3"]
         assert stats["hash_paths_orphaned_bytes"] == 200
-        assert stats["schema_paths_orphaned"] == 1 and stats["orphaned_paths"] == ["s/t/pk2/f"]
+        assert stats["schema_paths_orphaned"] == 1 and stats["orphaned_schema_paths"] == ["s/t/pk2/f"]
         assert stats["schema_paths_orphaned_bytes"] == 300
         # no combined totals
         for k in ("referenced", "stored", "orphaned", "orphaned_bytes"):
@@ -374,7 +374,7 @@ def test_custom_codec_reference_not_orphaned(self, schema_custom):
         live_path = next(iter(refs))
 
         stats = collector.collect()
-        assert live_path not in stats["orphaned_paths"], f"live custom-codec file wrongly flagged orphan: {live_path}"
+        assert live_path not in stats["orphaned_schema_paths"], f"live custom-codec file wrongly flagged orphan: {live_path}"
 
     def test_custom_codec_survives_collect(self, schema_custom):
         """#1469 end-to-end data-loss guard: collect() must delete only the
@@ -432,7 +432,7 @@ def _make_store_dir(tmp_path, name, n_chunks=3):
 
     def test_live_directory_object_not_orphaned(self, schema_dirobj, tmp_path):
         """A live folder object's chunk files and manifest must be covered by
-        its referenced prefix — none may appear in orphaned_paths."""
+        its referenced prefix — none may appear in orphaned_schema_paths."""
         GcObjectTest.insert1({"rid": 1, "results": str(self._make_store_dir(tmp_path, "live.zarr"))})
 
         collector = _gc(schema_dirobj)
@@ -446,7 +446,9 @@ def test_live_directory_object_not_orphaned(self, schema_dirobj, tmp_path):
         assert f"{ref}.manifest.json" in stored, "manifest sidecar must be listed (it is reclaimable state)"
 
         stats = collector.collect()
-        flagged = [p for p in stats["orphaned_paths"] if p == ref or p.startswith(ref + "/") or p == f"{ref}.manifest.json"]
+        flagged = [
+            p for p in stats["orphaned_schema_paths"] if p == ref or p.startswith(ref + "/") or p == f"{ref}.manifest.json"
+        ]
         assert not flagged, f"live directory object misclassified as orphaned: {flagged}"
 
     def test_orphaned_directory_object_fully_reclaimed(self, schema_dirobj, tmp_path):
@@ -609,7 +611,7 @@ def test_custom_sections_written_scanned_and_collected(self, schema_prefixed):
         stats = collector.collect()
         assert stats["hash_paths_referenced"] >= 1
         assert not (hash_refs & set(stats["orphaned_hash_paths"]))
-        assert not (obj_refs & set(stats["orphaned_paths"]))
+        assert not (obj_refs & set(stats["orphaned_schema_paths"]))
 
         # And reclamation works within the configured sections
         (GcObjectTest & {"rid": 2}).delete(prompt=False)
@@ -661,7 +663,7 @@ def test_live_hash_object_survives_prefix_change(self, schema_pfx):
 
             stats = collector.collect()
             assert hash_ref not in set(
-                stats["orphaned_paths"]
+                stats["orphaned_schema_paths"]
             ), "live hash object outside the current hash section must not be a schema orphan"
             assert hash_ref not in set(stats["orphaned_hash_paths"])
 
@@ -736,7 +738,7 @@ def test_scan_one_schema_ignores_the_other(self, two_schemas):
         stats = collector.collect()
         # b's live objects are outside a's subtree → not counted, not orphaned
         assert stats["hash_paths_orphaned"] == 0 and stats["schema_paths_orphaned"] == 0
-        assert not any(b.database in p for p in stats["orphaned_paths"] + stats["orphaned_hash_paths"])
+        assert not any(b.database in p for p in stats["orphaned_schema_paths"] + stats["orphaned_hash_paths"])
 
     def test_collect_one_schema_never_touches_the_other(self, two_schemas):
         a, b, b_blob, b_obj = two_schemas