Skip to content

Commit 34cdfc8

Browse files
committed
chore(release-flow): fix stale doc pointers and remove dead badge step
Three findings from #1503: - src/datajoint/version.py: header comment listed label_prs.yaml / release.yaml / post_release.yaml — none exist; actual workflows are draft_release.yaml and post_draft_release_published.yaml. - RELEASE_MEMO.md: Branch Structure table listed master as 2.1.x; bumped to 2.3.x to match current line. - .github/workflows/post_draft_release_published.yaml: removed the 'Update README.md badge' step. The seds targeted <a id='commit-since-release-link'>/<img id='commit-since-release-img'> elements that were removed from README in ff04914 (2026-01-04); the step ran empty every release, guarded by the follow-up git-diff-empty-commit check. Leaves finding 1 from #1503 (version.py timing at tag) open — that one is an architectural choice for the maintainer.
1 parent af76ab9 commit 34cdfc8

3 files changed

Lines changed: 2 additions & 14 deletions

File tree

.github/workflows/post_draft_release_published.yaml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -47,18 +47,6 @@ jobs:
4747
git add src/datajoint/version.py
4848
git commit -m "Update version.py to $VERSION"
4949
echo "BRANCH_NAME=$BRANCH_NAME" >> $GITHUB_ENV
50-
- name: Update README.md badge
51-
run: |
52-
# commits since the last release
53-
NEW_HREF="https://github.com/datajoint/datajoint-python/compare/${{ github.event.release.tag_name }}...master"
54-
NEW_SRC="https://img.shields.io/github/commits-since/datajoint/datajoint-python/${{ github.event.release.tag_name }}?color=red"
55-
# Update href in the <a> tag
56-
sed -i 's|\(<a id="commit-since-release-link"[^>]*href="\)[^"]*\(".*\)|\1'"$NEW_HREF"'\2|' README.md
57-
# Update src in the <img> tag
58-
sed -i 's|\(<img id="commit-since-release-img"[^>]*src="\)[^"]*\(".*\)|\1'"$NEW_SRC"'\2|' README.md
59-
git add README.md
60-
# Only commit if there are changes (handles re-runs gracefully)
61-
git diff --cached --quiet README.md || git commit -m "Update README.md badge to ${{ github.event.release.tag_name }}"
6250
- name: Set up Python ${{matrix.py_ver}}
6351
uses: actions/setup-python@v5
6452
with:

RELEASE_MEMO.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
| Branch | Purpose | Version |
66
|--------|---------|---------|
7-
| `master` | Main development | 2.1.x |
7+
| `master` | Main development | 2.3.x |
88
| `maint/2.0` | Maintenance releases | 2.0.x |
99

1010
For 2.0.x bugfixes:

src/datajoint/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# version bump auto managed by Github Actions:
2-
# label_prs.yaml(prep), release.yaml(bump), post_release.yaml(edit)
2+
# draft_release.yaml (draft), post_draft_release_published.yaml (bump + PR)
33
# manually set this version will be eventually overwritten by the above actions
44
__version__ = "2.3.1"

0 commit comments

Comments
 (0)