Skip to content

Commit 5093ee1

Browse files
fix(bots): drop dead PR_BASE_SHA env from engineer follow-up
Review follow-up (F1): reviewer flagged that engineer-bot-followup passes PR_BASE_SHA without the base-fetch step the reviewer follow-up has. Verified against the engine: the engineer follow-up (followup_runner.py / run.py) never reads PR_BASE_SHA — unlike the reviewer, it does no `git rev-list base..head` anchor verification. So it was dead env, not a missing-base risk. Remove it rather than adding an unused base-fetch step. Co-authored-by: Isaac Signed-off-by: eric-wang-1990 <e.wang@databricks.com>
1 parent 386635a commit 5093ee1

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

.github/workflows/engineer-bot-followup.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,6 @@ jobs:
117117
PR_NUMBER: ${{ github.event.pull_request.number }}
118118
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
119119
HEAD_BRANCH: ${{ github.event.pull_request.head.ref }}
120-
PR_BASE_SHA: ${{ github.event.pull_request.base.sha }}
121120
PR_TITLE: ${{ github.event.pull_request.title }}
122121
PR_URL: ${{ github.event.pull_request.html_url }}
123122
TRIGGER_COMMENT_ID: ${{ github.event.comment.id }}

0 commit comments

Comments
 (0)