From db9e7ed72f41b8ce3a7e32333a352b9f6a61b13a Mon Sep 17 00:00:00 2001 From: 3alpha <15694175+3alpha@users.noreply.github.com> Date: Wed, 8 Jul 2026 16:49:53 +0200 Subject: [PATCH 1/3] ci: use dappnode-build-hash reusable workflow Replaces the inlined build step (which used `--skip_save` and never posted an IPFS hash on PRs) with a thin caller for the new `dappnode/workflows/.github/workflows/dappnode-build-hash.yml@master` reusable workflow. `build.yml` now handles both push and PR events; `main.yml` is reduced to the release job only. Also upgrades `actions/checkout` to v7 and adds Node 24 setup for the release job. --- .github/workflows/build.yml | 17 +++++------------ .github/workflows/main.yml | 21 +++++---------------- 2 files changed, 10 insertions(+), 28 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c151a87..8061165 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,19 +1,12 @@ -name: Build test +name: Build + on: workflow_dispatch: pull_request: push: + paths-ignore: ["README.md"] jobs: build: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 - with: - node-version: 20 - - run: npx @dappnode/dappnodesdk github-action build - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - PINATA_API_KEY: ${{ secrets.PINATA_API_KEY }} - PINATA_SECRET_API_KEY: ${{ secrets.PINATA_SECRET_API_KEY }} + uses: dappnode/workflows/.github/workflows/dappnode-build-hash.yml@master + secrets: inherit diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f89c05c..81afb5b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,34 +1,23 @@ name: "Main" on: - pull_request: - workflow_dispatch: push: branches: - - "master" - "main" - "v[0-9]+.[0-9]+.[0-9]+" paths-ignore: - "README.md" + workflow_dispatch: jobs: - build-test: - runs-on: ubuntu-latest - if: github.event_name != 'push' - steps: - - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 - with: - node-version: 20 - - run: npx @dappnode/dappnodesdk github-action build --skip_save - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - release: name: Release runs-on: ubuntu-latest if: github.event_name == 'push' || github.event_name == 'repository_dispatch' || github.event_name == 'workflow_dispatch' steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 + - uses: actions/setup-node@v4 + with: + node-version: "24" - name: Publish run: npx @dappnode/dappnodesdk publish patch --dappnode_team_preset env: From 750fb4e2c683b11f8941939c5358e3447ea6f7bd Mon Sep 17 00:00:00 2001 From: 3alpha <15694175+3alpha@users.noreply.github.com> Date: Wed, 8 Jul 2026 17:08:57 +0200 Subject: [PATCH 2/3] ci: bump actions/setup-node to v6 --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 81afb5b..4e519f4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -15,7 +15,7 @@ jobs: if: github.event_name == 'push' || github.event_name == 'repository_dispatch' || github.event_name == 'workflow_dispatch' steps: - uses: actions/checkout@v7 - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v6 with: node-version: "24" - name: Publish From 3c9b9b88676c31a1581b350441c8fb32a88b1ea2 Mon Sep 17 00:00:00 2001 From: 3alpha <15694175+3alpha@users.noreply.github.com> Date: Wed, 8 Jul 2026 17:52:32 +0200 Subject: [PATCH 3/3] ci: drop pull_request trigger from build.yml The `push` event already fires when tropibot pushes commits to the feature branch, so the build, IPFS pin, and PR comment all happen once per commit. The `pull_request` event was firing the same workflow a second time as a no-op (--skip_save test build). The reusable workflow SDK auto-detects the event: `push` to a non-default branch builds + pins + comments, `push` to default does a test build, and (now unused) `pull_request` would do a test build. --- .github/workflows/build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8061165..f5ec9ab 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -2,7 +2,6 @@ name: Build on: workflow_dispatch: - pull_request: push: paths-ignore: ["README.md"]