Skip to content

fix: restore promoted by ad attribution#6374

Merged
rebelchris merged 2 commits into
mainfrom
codex/restore-promoted-by-attribution
Jul 24, 2026
Merged

fix: restore promoted by ad attribution#6374
rebelchris merged 2 commits into
mainfrom
codex/restore-promoted-by-attribution

Conversation

@rebelchris

@rebelchris rebelchris commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Restore ad attribution copy to show Promoted by {source} when a referral link exists
  • Pass ad data into ad attribution across list, grid, signal, and sidebar ad surfaces
  • Add regression coverage for linked and plain promoted attribution

Tests

  • NODE_ENV=test pnpm exec jest src/components/cards/ad/AdCard.spec.tsx --runInBand
  • node ./scripts/typecheck-strict-changed.js
  • pnpm --filter @dailydotdev/shared lint
  • pnpm --filter webapp build (passes TypeScript; blocked later by sandbox EPERM fetch to 127.0.0.1:443 while prerendering /gear)

Preview domain

https://codex-restore-promoted-by-attrib.preview.app.daily.dev

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Jul 24, 2026 12:02pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Jul 24, 2026 12:02pm

Request Review

@rebelchris
rebelchris merged commit c184588 into main Jul 24, 2026
12 checks passed
@rebelchris
rebelchris deleted the codex/restore-promoted-by-attribution branch July 24, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant