fix: avoid passing WidgetRef to OCP handler

Author: Cyrix126

lib/pages/open_crypto_pay/open_crypto_pay_send_handler.dart

@@ -11,14 +11,11 @@
 import 'dart:async';
 
 import 'package:flutter/material.dart';
-import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:opencryptopay/opencryptopay.dart';
 
 import '../../networking/http.dart';
 import '../../notifications/show_flush_bar.dart';
-import '../../providers/ui/preview_tx_button_state_provider.dart';
 import '../../utilities/amount/amount.dart';
-import '../../utilities/amount/amount_formatter.dart';
 import '../../utilities/logger.dart';
 import '../../utilities/show_loading.dart';
 import '../../utilities/util.dart';
@@ -36,10 +33,9 @@ CryptoCoin cryptoCoinFor(CryptoCurrency currency, {String? tokenSymbol}) =>
 
 class OpenCryptoPaySendHandler {
   OpenCryptoPaySendHandler({
-    required this.ref,
     required this.coin,
     required this.sendToController,
-    required this.cryptoAmountController,
+    required this.onAmountReceived,
     required this.setValidAddress,
     required this.isMounted,
     this.tokenSymbol,
@@ -51,10 +47,9 @@ class OpenCryptoPaySendHandler {
              service: OpenCryptoPayService(client: StackClient()),
            );
 
-  final WidgetRef ref;
   final CryptoCurrency coin;
   final TextEditingController sendToController;
-  final TextEditingController cryptoAmountController;
+  final void Function(Amount amount) onAmountReceived;
   final void Function(String address) setValidAddress;
   final bool Function() isMounted;
 
@@ -151,10 +146,7 @@ class OpenCryptoPaySendHandler {
         rawValue: rawAmount,
         fractionDigits: _fractionDigits,
       );
-      cryptoAmountController.text = ref
-          .read(pAmountFormatter(coin))
-          .format(parsed, withUnitName: false);
-      ref.read(pSendAmount.notifier).state = parsed;
+      onAmountReceived(parsed);
     }
 
     setValidAddress(address);

lib/pages/send_view/send_view.dart

@@ -1513,10 +1513,14 @@ class _SendViewState extends ConsumerState<SendView> {
     cryptoAmountController.addListener(onCryptoAmountChanged);
     baseAmountController.addListener(_baseAmountChanged);
     _openCryptoPay = OpenCryptoPaySendHandler(
-      ref: ref,
       coin: coin,
       sendToController: sendToController,
-      cryptoAmountController: cryptoAmountController,
+      onAmountReceived: (parsed) {
+        cryptoAmountController.text = ref
+            .read(pAmountFormatter(coin))
+            .format(parsed, withUnitName: false);
+        ref.read(pSendAmount.notifier).state = parsed;
+      },
       setValidAddress: _openCryptoPaySetValidAddress,
       isMounted: () => mounted,
     );

lib/pages/send_view/sol_token_send_view.dart

@@ -608,11 +608,16 @@ class _SolTokenSendViewState extends ConsumerState<SolTokenSendView> {
     }
 
     final tokenWallet = ref.read(pCurrentSolanaTokenWallet);
+    final coin = ref.read(pWallets).getWallet(walletId).info.coin;
     _openCryptoPay = OpenCryptoPaySendHandler(
-      ref: ref,
-      coin: ref.read(pWallets).getWallet(walletId).info.coin,
+      coin: coin,
       sendToController: sendToController,
-      cryptoAmountController: cryptoAmountController,
+      onAmountReceived: (parsed) {
+        cryptoAmountController.text = ref
+            .read(pAmountFormatter(coin))
+            .format(parsed, withUnitName: false);
+        ref.read(pSendAmount.notifier).state = parsed;
+      },
       setValidAddress: _openCryptoPaySetValidAddress,
       isMounted: () => mounted,
       tokenSymbol: tokenWallet?.tokenSymbol,

lib/pages/send_view/token_send_view.dart

@@ -636,10 +636,14 @@ class _TokenSendViewState extends ConsumerState<TokenSendView> {
     }
 
     _openCryptoPay = OpenCryptoPaySendHandler(
-      ref: ref,
       coin: coin,
       sendToController: sendToController,
-      cryptoAmountController: cryptoAmountController,
+      onAmountReceived: (parsed) {
+        cryptoAmountController.text = ref
+            .read(pAmountFormatter(coin))
+            .format(parsed, withUnitName: false);
+        ref.read(pSendAmount.notifier).state = parsed;
+      },
       setValidAddress: _openCryptoPaySetValidAddress,
       isMounted: () => mounted,
       tokenSymbol: tokenContract.symbol,

lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_send.dart

@@ -1263,10 +1263,14 @@ class _DesktopSendState extends ConsumerState<DesktopSend> {
     onCryptoAmountChanged = _cryptoAmountChanged;
     cryptoAmountController.addListener(onCryptoAmountChanged);
     _openCryptoPay = OpenCryptoPaySendHandler(
-      ref: ref,
       coin: coin,
       sendToController: sendToController,
-      cryptoAmountController: cryptoAmountController,
+      onAmountReceived: (parsed) {
+        cryptoAmountController.text = ref
+            .read(pAmountFormatter(coin))
+            .format(parsed, withUnitName: false);
+        ref.read(pSendAmount.notifier).state = parsed;
+      },
       setValidAddress: _openCryptoPaySetValidAddress,
       isMounted: () => mounted,
     );

lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_sol_token_send.dart

@@ -667,10 +667,14 @@ class _DesktopSolTokenSendState extends ConsumerState<DesktopSolTokenSend> {
 
     final tokenWallet = ref.read(pCurrentSolanaTokenWallet);
     _openCryptoPay = OpenCryptoPaySendHandler(
-      ref: ref,
       coin: coin,
       sendToController: sendToController,
-      cryptoAmountController: cryptoAmountController,
+      onAmountReceived: (parsed) {
+        cryptoAmountController.text = ref
+            .read(pAmountFormatter(coin))
+            .format(parsed, withUnitName: false);
+        ref.read(pSendAmount.notifier).state = parsed;
+      },
       setValidAddress: _openCryptoPaySetValidAddress,
       isMounted: () => mounted,
       tokenSymbol: tokenWallet?.tokenSymbol,

lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_token_send.dart

@@ -641,10 +641,14 @@ class _DesktopTokenSendState extends ConsumerState<DesktopTokenSend> {
 
     final tokenContract = ref.read(pCurrentTokenWallet)?.tokenContract;
     _openCryptoPay = OpenCryptoPaySendHandler(
-      ref: ref,
       coin: coin,
       sendToController: sendToController,
-      cryptoAmountController: cryptoAmountController,
+      onAmountReceived: (parsed) {
+        cryptoAmountController.text = ref
+            .read(pAmountFormatter(coin))
+            .format(parsed, withUnitName: false);
+        ref.read(pSendAmount.notifier).state = parsed;
+      },
       setValidAddress: _openCryptoPaySetValidAddress,
       isMounted: () => mounted,
       tokenSymbol: tokenContract?.symbol,

test/pages/open_crypto_pay/open_crypto_pay_send_handler_test.dart

@@ -189,10 +189,14 @@ _HandlerSetup _makeHandler({
   final amount = TextEditingController();
   final validAddresses = <String>[];
   final handler = OpenCryptoPaySendHandler(
-    ref: harness.ref,
     coin: coin,
     sendToController: sendTo,
-    cryptoAmountController: amount,
+    onAmountReceived: (parsed) {
+      amount.text = harness.ref
+          .read(pAmountFormatter(coin))
+          .format(parsed, withUnitName: false);
+      harness.ref.read(pSendAmount.notifier).state = parsed;
+    },
     setValidAddress: validAddresses.add,
     isMounted: isMounted ?? () => true,
     tokenSymbol: tokenSymbol,