Fix #11604 Debug: DacaWrongData (#8752)

Co-authored-by: chrchr-github <noreply@github.com>

Author: chrchr-github

lib/check.h

@@ -39,9 +39,6 @@ class Settings;
 class ErrorLogger;
 class Tokenizer;
 
-/** Use WRONG_DATA in checkers to mark conditions that check that data is correct */
-#define WRONG_DATA(COND, TOK)  ((COND) && wrongData((TOK), #COND))
-
 /// @addtogroup Core
 /// @{
 

lib/checkclass.cpp

@@ -1251,7 +1251,7 @@ void CheckClassImpl::initializationListUsage()
                 continue;
             if (var->isPointer() || var->isReference() || var->isEnumType())
                 continue;
-            if (!WRONG_DATA(!var->valueType(), tok) && var->valueType()->type > ValueType::Type::ITERATOR)
+            if (!var->valueType() || var->valueType()->type > ValueType::Type::ITERATOR)
                 continue;
 
             // bailout: multi line lambda in rhs => do not warn

lib/checkfunctions.cpp

@@ -543,9 +543,9 @@ void CheckFunctionsImpl::memsetZeroBytes()
     const SymbolDatabase *symbolDatabase = mTokenizer->getSymbolDatabase();
     for (const Scope *scope : symbolDatabase->functionScopes) {
         for (const Token* tok = scope->bodyStart->next(); tok != scope->bodyEnd; tok = tok->next()) {
-            if (Token::Match(tok, "memset|wmemset (") && (numberOfArguments(tok)==3)) {
+            if (Token::Match(tok, "memset|wmemset (")) {
                 const std::vector<const Token *> &arguments = getArguments(tok);
-                if (WRONG_DATA(arguments.size() != 3U, tok))
+                if (arguments.size() != 3U)
                     continue;
                 const Token* lastParamTok = arguments[2];
                 if (MathLib::isNullValue(lastParamTok->str()))

lib/checkimpl.cpp

@@ -40,13 +40,6 @@ void CheckImpl::reportError(ErrorPath errorPath, Severity severity, const char i
     mErrorLogger.reportErr(errmsg);
 }
 
-bool CheckImpl::wrongData(const Token *tok, const char *str)
-{
-    if (mSettings.daca)
-        reportError(tok, Severity::debug, "DacaWrongData", "Wrong data detected by condition " + std::string(str));
-    return true;
-}
-
 ErrorPath CheckImpl::getErrorPath(const Token* errtok, const ValueFlow::Value* value, std::string bug) const
 {
     ErrorPath errorPath;

lib/checkimpl.h

@@ -72,12 +72,6 @@ class CPPCHECKLIB CheckImpl
 
     ErrorPath getErrorPath(const Token* errtok, const ValueFlow::Value* value, std::string bug) const;
 
-    /**
-     * Use WRONG_DATA in checkers when you check for wrong data. That
-     * will call this method
-     */
-    bool wrongData(const Token *tok, const char *str);
-
 public: // TODO: should be protected
     void logChecker(const char id[]);
 };