From 4f1694154517adf1e7029dc5107e2a0f4deb2a3b Mon Sep 17 00:00:00 2001 From: Dan Lynch Date: Sat, 8 Aug 2026 00:19:38 +0000 Subject: [PATCH] ci: make package test failures fail the build, cover four untested packages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test job carried continue-on-error: true, so a red package test reported as a failed check but left the workflow green — the object-tree verify/revert signature bug reached main that way. The matrix also skipped every package with tests that was added after it was written. Also drops the 'pnpm -r build' step from both workflows: no package in the workspace declares a build script, so it is a no-op under pnpm 9 and an error under pnpm 10. --- .github/workflows/ci.yml | 8 ++++---- .github/workflows/integration-test.yml | 3 --- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5320de87..bc3e3a8d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,7 +9,6 @@ on: jobs: test: runs-on: ubuntu-latest - continue-on-error: true strategy: fail-fast: false matrix: @@ -35,6 +34,10 @@ jobs: - types - stamps - geotypes + - inflection-db + - object-store + - object-tree + - partman env: PGHOST: localhost @@ -112,9 +115,6 @@ jobs: - name: Tune Postgres for CI (disable durability) run: pgpm tune --yes - - name: Build - run: pnpm -r build - - name: Seed pg and app_user run: | pgpm admin-users bootstrap --yes diff --git a/.github/workflows/integration-test.yml b/.github/workflows/integration-test.yml index 74d3b28b..42258446 100644 --- a/.github/workflows/integration-test.yml +++ b/.github/workflows/integration-test.yml @@ -83,9 +83,6 @@ jobs: - name: Tune Postgres for CI (disable durability) run: pgpm tune --yes - - name: Build - run: pnpm -r build - - name: Seed pg users run: | pgpm admin-users bootstrap --yes