Skip to content

Migrate Renovate config - #3353

Merged
red-hat-konflux[bot] merged 0 commit into
mainfrom
konflux/mintmaker/migrate-config
Aug 24, 2026
Merged

Migrate Renovate config#3353
red-hat-konflux[bot] merged 0 commit into
mainfrom
konflux/mintmaker/migrate-config

Conversation

@red-hat-konflux

Copy link
Copy Markdown
Contributor

The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed.

You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon.

🔕 Ignore: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid.

❓ Got questions? Does something look wrong to you? Please don't hesitate to request help here.


To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/migrate-config branch from 232a6c9 to 9d051fb Compare June 22, 2026 15:25
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:28 PM UTC · Completed 3:32 PM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review — ✅ Approve

PR: #3353 — Migrate Renovate config
Author: red-hat-konflux[bot]
Scope: 1 file changed (renovate.json), +3 / −1

Summary

This PR migrates the Renovate configuration field fileMatch to its successor managerFilePatterns, as prompted by the Renovate bot itself. The migration is straightforward and correct:

  • The deprecated fileMatch key is replaced with managerFilePatterns
  • The regex pattern \.tekton/.*\.yaml$ is correctly wrapped in / delimiters (required by managerFilePatterns to distinguish regex patterns from glob patterns)
  • The regex semantics are unchanged — the same .tekton/*.yaml files will be matched

Dimension Results

Dimension Result
Correctness ✅ Migration syntax is correct. No stale fileMatch references elsewhere in the repo.
Security ✅ No secrets, injection vectors, or permission changes. Config-only change.
Intent & Coherence ✅ Mechanical bot-generated change. Authorization implicit from nature of change.
Style & Conventions ✅ No findings. Follows existing JSON formatting.
Documentation ✅ No stale Renovate fileMatch references in repo documentation.
Cross-repo Contracts ⏭ Skipped — no exported APIs or interfaces modified.

Notes

Other Renovate deprecated fields (customType, datasourceTemplate) remain in the config. These are still functional and Renovate will continue to migrate them internally at runtime. If Renovate raises a follow-up migration PR for these fields, it can be handled then.

Previous run

Looks good to me

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 22, 2026
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 53.62% <ø> (ø)
generative 17.18% <ø> (ø)
integration 28.36% <ø> (ø)
unit 71.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
github-actions Bot enabled auto-merge July 13, 2026 21:06
@simonbaird

Copy link
Copy Markdown
Member

Needs a rebase probably.

@simonbaird
simonbaird force-pushed the konflux/mintmaker/migrate-config branch from 9d051fb to 7322838 Compare July 13, 2026 21:12
@simonbaird

Copy link
Copy Markdown
Member

Rebased.

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 13, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:13 PM UTC · Completed 9:21 PM UTC
Commit: 87c4a29 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels Jul 13, 2026
@robnester-rh

Copy link
Copy Markdown
Contributor

/fs-fix rebase on top of main and resolve conflicts

@fullsend-ai-coder

fullsend-ai-coder Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

🤖 Fix · ⚠️ Cancelled · Started 2:13 PM UTC · Ended 2:14 PM UTC

Commit: 87c4a29 · View workflow run →

@fullsend-ai-coder

fullsend-ai-coder Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

🤖 Finished Fix · ✅ Success · Started 2:15 PM UTC · Completed 2:20 PM UTC

Commit: 87c4a29 · View workflow run →

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

🔧 Fix agent — iteration 1 (human-triggered)

Successfully rebased konflux/mintmaker/migrate-config onto origin/main (168 commits behind). Resolved merge conflict in renovate.json by accepting main's version — the customManagers section was removed from main, so the fileMatch-to-managerFilePatterns migration is no longer needed. The PR branch now has no diff from main and can be closed.

Fixed (1):

  1. rebase on top of main and resolve conflicts: Rebased the branch onto origin/main. Resolved the merge conflict in renovate.json by accepting main's version. The customManagers section (which the PR was migrating from fileMatch to managerFilePatterns) was removed from main in a prior commit, making the migration unnecessary. The original PR commit was dropped during rebase as it produced an empty diff after conflict resolution. The branch now has no diff from main — this PR can be closed.

Tests: passed

Next steps:

  • /fs-review — request a re-review of the changes
  • /fs-fix <your instruction> — run another fix pass with specific guidance
  • Push commits directly — review re-runs automatically on push
    Updated by fullsend fix agent

auto-merge was automatically disabled August 24, 2026 14:20

Pull request was closed

@fullsend-ai-coder
fullsend-ai-coder Bot force-pushed the konflux/mintmaker/migrate-config branch from 7322838 to fa2d487 Compare August 24, 2026 14:20
@red-hat-konflux
red-hat-konflux Bot merged commit fa2d487 into main Aug 24, 2026
21 of 22 checks passed
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 24, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:21 PM UTC · Completed 2:24 PM UTC

Commit: 87c4a29 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open pull requests.

Posted by fullsend pre-review check

@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 24, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 2:22 PM UTC · Completed 2:28 PM UTC

Commit: 87c4a29 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open pull requests.

Posted by fullsend post-review check

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #3353 — Migrate Renovate config

Outcome: A Renovate config migration PR sat open for 63 days, was rebased by the fix agent into a zero-diff state, and then auto-merged as a no-op due to a race condition. The workflow was functional but produced avoidable waste.

Timeline

  1. Jun 22: Renovate bot opened PR to migrate fileMatchmanagerFilePatterns in renovate.json.
  2. Jun 22: Review agent approved with a thorough dimension-based review — correct assessment of a straightforward config migration.
  3. Jul 13: Human (simonbaird) approved, noted rebase needed, and rebased the PR. Auto-merge was enabled.
  4. Jul 13: Review agent re-ran and approved again (triggered by the rebase push).
  5. Aug 24: Human (robnester-rh) triggered /fs-fix rebase on top of main and resolve conflicts — the branch was 168 commits behind main.
  6. Aug 24: Fix agent ran, rebased successfully, resolved the merge conflict by accepting main's version (the customManagers section had been removed from main in a prior commit). This made the entire migration moot — zero diff from main.
  7. Aug 24: Fix agent posted "can be closed" but force-pushed the zero-diff branch. Auto-merge (enabled since Jul 13) fired within 2 seconds, merging a PR with 0 additions, 0 deletions, 0 changed files.
  8. Aug 24: Review agent dispatched on the merged PR, only to skip — wasted workflow run.

Assessment

The review agent performed well on both reviews — the initial approval was thorough and correctly identified the migration as safe. The fix agent's rebase and conflict resolution logic was sound. The breakdown was in the post-fix workflow: the fix agent recognized the zero-diff state (recommending closure) but didn't act on it, and the post-script force-pushed without disabling auto-merge first, causing a no-op merge.

All identified improvements map to existing open issues — no new proposals needed:

One nuance worth noting for #2585: the current proposal describes a post-push check, but this retro shows the check (or at minimum, disabling auto-merge) must happen before the force-push to prevent the race condition. If auto-merge fires during the 2-second window between push and close, the PR gets merged as a no-op.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main ready-for-merge All reviewers approved — ready to merge renovate size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants