From e23f5ed5f95e0ecb84cb471f12e273ba5c646515 Mon Sep 17 00:00:00 2001
From: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Date: Sat, 13 Jun 2026 02:14:51 -0700
Subject: [PATCH] fix: replace iframe with link in build_inspect_data

cppreference.com sets X-Frame-Options: DENY (MediaWiki default), which
causes every browser to block the <iframe> used in build_inspect_data.
Replace it with a plain <a> anchor that opens the documentation URL in
a new tab, keeping the existing text/plain field intact.

Adds a unit test asserting the output contains an <a href> and no
<iframe>.

Fixes #484
---
 src/xinspect.cpp          | 23 ++++++-----------------
 test/test_interpreter.cpp | 13 +++++++++++++
 2 files changed, 19 insertions(+), 17 deletions(-)

diff --git a/src/xinspect.cpp b/src/xinspect.cpp
index 1ec45717..7583f0b6 100644
--- a/src/xinspect.cpp
+++ b/src/xinspect.cpp
@@ -198,23 +198,12 @@ namespace xcpp
     nl::json build_inspect_data(const std::string& inspect_result)
     {
         // Format html content.
-        std::string html_content = R"(<style>
-        #pager-container {
-            padding: 0;
-            margin: 0;
-            width: 100%;
-            height: 100%;
-        }
-        .xcpp-iframe-pager {
-            padding: 0;
-            margin: 0;
-            width: 100%;
-            height: 100%;
-            border: none;
-        }
-        </style>
-        <iframe class="xcpp-iframe-pager" src=")"
-                                   + inspect_result + R"(?action=purge"></iframe>)";
+        // Note: cppreference.com sets X-Frame-Options: DENY, so an <iframe> is
+        // blocked by every browser.  Use a plain link that opens in a new tab
+        // instead.
+        std::string html_content = R"(<a href=")" + inspect_result
+                                   + R"(" target="_blank" rel="noopener noreferrer">)"
+                                   + inspect_result + R"(</a>)";
 
         auto data = nl::json::object({{"text/plain", inspect_result}, {"text/html", html_content}});
         return data;
diff --git a/test/test_interpreter.cpp b/test/test_interpreter.cpp
index a1a11f57..159a8e01 100644
--- a/test/test_interpreter.cpp
+++ b/test/test_interpreter.cpp
@@ -1014,6 +1014,19 @@ TEST_SUITE("xinspect"){
         cmp.child_value = "nonexistentMethod";
         REQUIRE(cmp(node) == false);
     }
+
+    TEST_CASE("build_inspect_data_link_not_iframe"){
+        // cppreference.com sets X-Frame-Options: DENY, so the output must use
+        // an <a> link instead of an <iframe>.
+        std::string url = "https://en.cppreference.com/w/cpp/container/vector";
+        nl::json data = xcpp::build_inspect_data(url);
+
+        REQUIRE(data.contains("text/html"));
+        std::string html = data["text/html"].get<std::string>();
+        REQUIRE(html.find("<iframe") == std::string::npos);
+        REQUIRE(html.find(url) != std::string::npos);
+        REQUIRE(html.find("<a href=") != std::string::npos);
+    }
 }
 
 #if !defined(__EMSCRIPTEN__)