fix(version): recognize PEP 440 development tags - #2026
Open
ychampion wants to merge 1 commit into
Open
Conversation
Keep development-release tags discoverable across sequential bumps while preserving custom tag embedding and existing suffix behavior. Constraint: Preserve custom tag formats and SemVer-compatible parsing. Rejected: Replace the shared parser with the anchored PEP 440 reference regex | it breaks embedded tag formats and unrelated schemes. Confidence: high Scope-risk: narrow Directive: Keep generated version forms round-trippable through TagRules. Tested: uv run poe all; 446 focused tag, version, bump, and changelog tests; exact uv-provider sequential bump regression; git diff --check. Not-tested: Full tox matrix across every supported Python version and operating system.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2026 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 61 61
Lines 2784 2784
=======================================
Hits 2735 2735
Misses 49 49 ☔ View full report in Codecov by Harness. |
Manny7717
approved these changes
Aug 29, 2026
Manny7717
left a comment
Manny7717
left a comment
There was a problem hiding this comment.
Verified locally against head bca897506ad1242431ac6365347f62fd694015e0 (commitizen master + this PR's 3 files):
- Regression proven: on master's code,
TagRules().is_version_tag("0.2.0.dev0")is False andextract_versionraisesInvalidVersion— same for0.2.0.dev0+build.1,0.2.0a1.dev0,0.2.0a1.dev0+build.1,2.0.0.dev0, and1.2.3rc1+build5. With this PR all parse correctly; the newtest_is_version_tag_accepts_pep440_devreleasefails on master and passes here. - No regressions (differential battery, 15 tags incl.
1.2.3,v1.2.3,1.2.3rc1,1.2.3-dev1,1.2.3+build.1,0.2.0dev0,0.1.0): every tag recognized on master is recognized identically here;0.2.0.not-a-releasestays rejected. The change is strictly additive — it only accepts previously-rejected valid PEP 440 forms. - Group numbering unchanged (
(\w+)?→(?:\w+)?, build group was never captured), so nothing referencing the old groups breaks. - Tests:
tests/test_tags.py+tests/test_version_schemes.py= 16 passed;test_bump_command.py::test_bump_devrelease_with_incremental_changelogpasses (exercises two realbump --devreleaseruns incl. uv-provider version sync + incremental changelog); ruff clean on all touched files.
One non-blocking nit: the dotless forms (0.2.0dev0) normalize correctly via packaging, but the new test's 0.2.0.dev0+build.1 round-trip depends on str(Version) normalization — worth keeping in mind if a custom tag_format ever needs the literal string preserved. Not a blocker.
Fix is correct, minimal, and well-tested — approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1367.
The default
$versionparser rejected.devNtags that Commitizen itself creates. This keeps generated PEP 440 prerelease, development, and local-version combinations discoverable so the next incremental changelog can find the previous tag.Checklist
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines
Code Changes
uv-provider bumpsuv run poe alllocallyExpected Behavior
After creating
0.2.0.dev0, a subsequent--devrelease 1bump should recognize that tag and generate the0.2.0.dev1changelog, tag,pyproject.toml, anduv.lockupdates.Steps to Test This Pull Request
uvversion provider withupdate_changelog_on_bumpandchangelog_incrementalenabled.cz bump --devrelease 0 --yesafter a feature commit.cz bump --devrelease 1 --yes.0.2.0.dev1to the tag, changelog,pyproject.toml, anduv.lock.