fix: throw Postgre query errors with warnings disabled - #10573
Merged
paulbalandan merged 3 commits intoSep 27, 2026
Merged
paulbalandan merged 3 commits into
paulbalandan merged 3 commits into
Conversation
wakqasahmed
changed the title
carson-codeigniter4
Bot
added
the
bug
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
|
Hi @wakqasahmed , Thanks for your PR. Few reminders on your PRs:
|
wakqasahmed
force-pushed
the
feature/issue-6913-postgre-exception
branch
from
September 25, 2026 20:34
6d7297a to
2382e28
Compare
Contributor
Author
|
Added the changelog entry to v4.7.5 and rebased on the latest develop. Thanks! @paulbalandan noted on both points, sorry for the noise. I'll stick to the template and keep the review stuff out of the PR from now on. |
datamweb
approved these changes
Sep 25, 2026
michalsn
approved these changes
Sep 27, 2026
paulbalandan
approved these changes
Sep 27, 2026
paulbalandan
changed the title
Member
|
Thanks, @wakqasahmed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Throws
DatabaseExceptionwhen Postgre'spg_query()returnsfalsewithDBDebugenabled, even if PHP warnings are disabled — previously the failure was silently swallowed in that combination. Adds a Postgre regression test for the suppressed-warning query failure. Partially addresses #6913; OCI8 remains open, this PR does not close the issue.Checklist: