What
Delete trapfall-alert crate (3 LOC stub containing only // TODO: Phase 0 — scaffold only).
Why
BMAD COO finding: The alert engine is fully implemented in trapfalld/src/alert.rs (266 LOC) — webhook dispatch, cooldown logic, rule matching, alert history. The standalone trapfall-alert crate contributes nothing. It's pulled into trapfalld's Cargo.toml but adds zero code. This is organizational fiction that misleads contributors about where alerting logic lives.
Impact: Contributors seeing trapfall-alert expect to find alert logic there. They won't. This creates onboarding friction and maintenance overhead (extra Cargo.toml, dependency declarations, workspace member).
Changes
- Remove
trapfall-alert/ directory entirely
- Remove
"crates/trapfall-alert" from root Cargo.toml workspace members
- Remove
trapfall-alert dependency from trapfalld/Cargo.toml
- If any re-exports reference the crate, move them to
trapfalld/src/lib.rs or wherever appropriate
- Verify
cargo build --workspace passes
- Verify
cargo test --workspace passes
Testing
cargo build --workspace — must pass
cargo test --workspace — all 231 tests must still pass
cargo clippy --workspace --all-targets -- -D warnings — clean
- Verify alert functionality still works (webhook dispatch, cooldowns, rule matching)
What
Delete
trapfall-alertcrate (3 LOC stub containing only// TODO: Phase 0 — scaffold only).Why
BMAD COO finding: The alert engine is fully implemented in
trapfalld/src/alert.rs(266 LOC) — webhook dispatch, cooldown logic, rule matching, alert history. The standalonetrapfall-alertcrate contributes nothing. It's pulled into trapfalld's Cargo.toml but adds zero code. This is organizational fiction that misleads contributors about where alerting logic lives.Impact: Contributors seeing
trapfall-alertexpect to find alert logic there. They won't. This creates onboarding friction and maintenance overhead (extra Cargo.toml, dependency declarations, workspace member).Changes
trapfall-alert/directory entirely"crates/trapfall-alert"from rootCargo.tomlworkspace memberstrapfall-alertdependency fromtrapfalld/Cargo.tomltrapfalld/src/lib.rsor wherever appropriatecargo build --workspacepassescargo test --workspacepassesTesting
cargo build --workspace— must passcargo test --workspace— all 231 tests must still passcargo clippy --workspace --all-targets -- -D warnings— clean