fix(table-core): guard Array.isArray before index access in range filter autoRemove (TanStack#6394)

* fix(table-core): guard Array.isArray before index access in range filter autoRemove

`filterFn_between`, `filterFn_betweenInclusive`, and
`filterFn_inNumberRange` shared an `autoRemove` that did
`testFalsy(val[0]) && testFalsy(val[1])`. When a scalar value such as
`99` was passed instead of a `[min, max]` tuple, `val[0]` and
`val[1]` were both `undefined`, so the condition evaluated to
`true && true` and the filter was silently auto-removed.

Numeric columns default to `inNumberRange` via
`column_getAutoFilterFn`, so calling `col.setColumnFilter(99)` on a
numeric column discarded the filter before the row scan even ran.

Wrap the index checks in `Array.isArray(val) &&`. The leading
`testFalsy(val)` still handles `undefined`, `null`, `0`, and
`''`. Behavior of the existing array-tuple cases is unchanged because
`Array.isArray` is true and short-circuits to the same boolean.

Closes TanStack#6353

* test(filterFns): assert empty-string scalar IS auto-removed

The previous regression test for TanStack#6353 bundled the non-empty scalar
case (autoRemove(99) and autoRemove(0)) with an empty-string
expectation (autoRemove('')). testFalsy treats '' as falsy, so the
leading testFalsy(val) branch correctly returns true for '' - the
Array.isArray guard added in 0041efb is intentionally additive and
not meant to override that behavior.

Split the assertion: the non-empty scalar test now stands alone with
just autoRemove(99) and autoRemove(0); the empty-string behavior is
covered by a separate explicit assertion (expect(autoRemove(''))).toBe(true))

Vitest run:
  Test Files  1 passed (1)
  Tests  73 passed (73)

Signed-off-by: sanjibani <18418553+sanjibani@users.noreply.github.com>

---------

Signed-off-by: sanjibani <18418553+sanjibani@users.noreply.github.com>
Co-authored-by: sanjibani <18418553+sanjibani@users.noreply.github.com>
Co-authored-by: JSap0914

Author: sanjibani

packages/table-core/src/fns/filterFns.ts

@@ -246,7 +246,8 @@ const filterFn_between = Object.assign(
   },
   {
     autoRemove: (val: any) =>
-      testFalsy(val) || (testFalsy(val[0]) && testFalsy(val[1])),
+      testFalsy(val) ||
+      (Array.isArray(val) && testFalsy(val[0]) && testFalsy(val[1])),
   },
 )
 
@@ -285,7 +286,8 @@ const filterFn_betweenInclusive = Object.assign(
   },
   {
     autoRemove: (val: any) =>
-      testFalsy(val) || (testFalsy(val[0]) && testFalsy(val[1])),
+      testFalsy(val) ||
+      (Array.isArray(val) && testFalsy(val[0]) && testFalsy(val[1])),
   },
 )
 
@@ -329,7 +331,8 @@ export const filterFn_inNumberRange = Object.assign(
       return [min, max] as const
     },
     autoRemove: (val: any) =>
-      testFalsy(val) || (testFalsy(val[0]) && testFalsy(val[1])),
+      testFalsy(val) ||
+      (Array.isArray(val) && testFalsy(val[0]) && testFalsy(val[1])),
   },
 )
 

packages/table-core/tests/unit/fns/filterFns.test.ts

@@ -593,6 +593,12 @@ describe('Filter Functions', () => {
         expect(autoRemove([undefined, 10])).toBe(false)
         expect(autoRemove([5, undefined])).toBe(false)
       })
+      it('should NOT auto-remove a scalar value passed instead of a range tuple', () => {
+        // Regression test for #6353 - without the Array.isArray guard,
+        // `val[0]` and `val[1]` are undefined for a scalar and the index
+        // checks incorrectly auto-remove the filter.
+        expect(autoRemove(99 as any)).toBe(false)
+      })
     })
 
     describe('filterFns.betweenInclusive.autoRemove', () => {
@@ -617,6 +623,49 @@ describe('Filter Functions', () => {
         expect(autoRemove([undefined, 10])).toBe(false)
         expect(autoRemove([5, undefined])).toBe(false)
       })
+      it('should NOT auto-remove a scalar value passed instead of a range tuple', () => {
+        // Regression test for #6353 - same Array.isArray guard needed
+        // here as in `between` and `inNumberRange`.
+        expect(autoRemove(99 as any)).toBe(false)
+      })
+    })
+
+    describe('filterFns.inNumberRange.autoRemove', () => {
+      const autoRemove = filterFns.inNumberRange.autoRemove!
+
+      it('should auto-remove when both endpoints are undefined', () => {
+        expect(autoRemove([undefined, undefined])).toBe(true)
+      })
+      it('should auto-remove when both endpoints are null', () => {
+        expect(autoRemove([null, null])).toBe(true)
+      })
+      it('should auto-remove when both endpoints are empty strings', () => {
+        expect(autoRemove(['', ''])).toBe(true)
+      })
+      it('should NOT auto-remove when both endpoints are valid numbers', () => {
+        expect(autoRemove([5, 10])).toBe(false)
+      })
+      it('should NOT auto-remove when lower bound is 0 (falsy number)', () => {
+        expect(autoRemove([0, 10])).toBe(false)
+      })
+      it('should NOT auto-remove when only one endpoint is provided', () => {
+        expect(autoRemove([undefined, 10])).toBe(false)
+        expect(autoRemove([5, undefined])).toBe(false)
+      })
+      it('should NOT auto-remove a non-empty scalar number passed instead of a range tuple', () => {
+        // Regression test for #6353 - `val[0]` and `val[1]` were both
+        // undefined for a non-array scalar, so the previous index checks
+        // produced true && true and the filter was discarded.
+        expect(autoRemove(99 as any)).toBe(false)
+        expect(autoRemove(0 as any)).toBe(false)
+      })
+      it('should auto-remove an empty-string scalar (matches existing testFalsy behavior)', () => {
+        // `testFalsy` treats '' as falsy, and the leading `testFalsy(val)`
+        // branch short-circuits to true for an empty string. The new
+        // Array.isArray guard is intentionally additive and only kicks in
+        // when the value is not already caught by `testFalsy`.
+        expect(autoRemove('' as any)).toBe(true)
+      })
     })
   })