diff --git a/packages/cubejs-api-gateway/src/sql-server.ts b/packages/cubejs-api-gateway/src/sql-server.ts index 28d2cc94c0a44..8b362ae57ce66 100644 --- a/packages/cubejs-api-gateway/src/sql-server.ts +++ b/packages/cubejs-api-gateway/src/sql-server.ts @@ -194,34 +194,6 @@ export class SQLServer { } }); }, - load: async ({ request, session, query }) => { - const context = await contextByRequest(request, session); - - // eslint-disable-next-line no-async-promise-executor - return new Promise(async (resolve, reject) => { - try { - await this.apiGateway.load({ - query, - queryType: 'multi', - context, - res: (response) => { - if ('error' in response) { - reject({ - message: response.error - }); - - return; - } - - resolve(response); - }, - apiType: 'sql', - }); - } catch (e) { - reject(e); - } - }); - }, sqlApiLoad: async ({ request, session, query, queryKey, sqlQuery, streaming, cacheMode }) => { const context = await contextByRequest(request, session); diff --git a/packages/cubejs-backend-native/js/index.ts b/packages/cubejs-backend-native/js/index.ts index df6989e3bdc95..440e8726c28a9 100644 --- a/packages/cubejs-backend-native/js/index.ts +++ b/packages/cubejs-backend-native/js/index.ts @@ -110,7 +110,6 @@ export type SQLInterfaceOptions = { contextToApiScopes: (payload: ContextToApiScopesPayload) => ContextToApiScopesResponse | Promise, checkAuth: (payload: CheckAuthPayload) => CheckAuthResponse | Promise, checkSqlAuth: (payload: CheckSQLAuthPayload) => CheckSQLAuthResponse | Promise, - load: (payload: LoadPayload) => unknown | Promise, sql: (payload: SqlPayload) => unknown | Promise, meta: (payload: MetaPayload) => unknown | Promise, stream: (payload: LoadPayload) => unknown | Promise, @@ -396,10 +395,6 @@ export const registerInterface = async (options: SQLInterfaceOptions): Promise { - const load = async ({ request, session, query }) => { - console.log('[js] load', { - request, - session, - query, - }); - - throw new Error('load is not implemented'); - }; - const sqlApiLoad = async ({ request, session, query, streaming }) => { console.log('[js] sqlApiLoad', { request, @@ -122,7 +112,6 @@ const meta_fixture = require('./meta'); const server = await native.registerInterface({ // nonce: '12345678910111213141516'.substring(0, 20), checkAuth, - load, sql, meta, stream, diff --git a/packages/cubejs-backend-native/test/sql.test.ts b/packages/cubejs-backend-native/test/sql.test.ts index e5d9af983b35c..ad4e2771cb00c 100644 --- a/packages/cubejs-backend-native/test/sql.test.ts +++ b/packages/cubejs-backend-native/test/sql.test.ts @@ -25,26 +25,8 @@ const _logger = jest.fn(({ event }) => { function interfaceMethods() { return { - load: jest.fn(async ({ request, session, query }) => { - console.log('[js] load', { - request, - session, - query, - }); - - expect(session).toEqual({ - user: expect.toBeTypeOrNull(String), - superuser: expect.any(Boolean), - securityContext: { foo: 'bar' }, - }); - - // It's just an emulation that ApiGateway returns error - return { - error: 'This error should be passed back to PostgreSQL client', - }; - }), sqlApiLoad: jest.fn(async ({ request, session, query, streaming }) => { - console.log('[js] load', { + console.log('[js] sqlApiLoad', { request, session, query, @@ -282,7 +264,6 @@ describe('SQLInterface', () => { }); try { - // limit is used to router query to load method instead of stream await connection.query( 'select * from KibanaSampleDataEcommerce LIMIT 1000' );