Skip to content

Bump Microsoft.NET.Test.Sdk from 16.10.0 to 17.3.3#59

Open
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/nuget/test/Codacy.Engine.Seed.Tests/Microsoft.NET.Test.Sdk-17.3.3
Open

Bump Microsoft.NET.Test.Sdk from 16.10.0 to 17.3.3#59
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/nuget/test/Codacy.Engine.Seed.Tests/Microsoft.NET.Test.Sdk-17.3.3

Conversation

@dependabot
Copy link
Copy Markdown

@dependabot dependabot Bot commented on behalf of github May 4, 2026

Updated Microsoft.NET.Test.Sdk from 16.10.0 to 17.3.3.

Release notes

Sourced from Microsoft.NET.Test.Sdk's releases.

17.3.3

See the release notes here.

17.3.2

See the release notes here.

17.3.1

See the release notes here.

17.3.0

See the release notes here.

17.3.0-preview-20220612-01

See the release notes here.

17.3.0-preview-20220530-08

See the release notes here.

17.3.0-preview-20220426-02

See the release notes here.

17.2.1

See the release notes here.

17.2.0

See the release notes here.

17.2.0-preview-20220401-08

See the release notes here.

17.2.0-preview-20220401-07

See the release notes here.

17.2.0-preview-20220301-01

See the release notes here.

17.2.0-preview-20220131-20

See the release notes here.

17.1.0

See the release notes here.

17.1.0-release-20220113-05

See the release notes here.

17.1.0-preview-20211130-02

See the release notes here.

17.1.0-preview-20211109-03

See the release notes here.

17.0.2

See the release notes here.

17.0.0

See the release notes here.

16.11.0

See the release notes here.

Commits viewable in compare view.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-version: 17.3.3
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels May 4, 2026
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown

@codacy-production codacy-production Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

While the PR successfully upgrades Microsoft.NET.Test.Sdk to 17.3.3 and meets Codacy standards, it introduces significant transitive dependency changes that are not reflected in the title. Specifically, Newtonsoft.Json and System.Collections.Immutable are undergoing major version upgrades (v12 to v13 and v1.5 to v5.0 respectively).

These changes present a risk of breaking serialization logic or collection behavior. Furthermore, there is a discrepancy between the PR title (which claims a bump from 16.10.0) and the lock file (which shows the previous version as 16.3.0). Verification of compatibility with these new major versions is required before merging.

About this PR

  • The PR title and description claim a bump from version 16.10.0, but the packages.lock.json diff indicates the previous version was 16.3.0. Please verify the intended baseline.

Test suggestions

  • Verify successful execution of the test suite with the updated Microsoft.NET.Test.Sdk 17.3.3.
  • Verify that the project code is compatible with the major version upgrades of Newtonsoft.Json (v13) and System.Collections.Immutable (v5).
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify successful execution of the test suite with the updated Microsoft.NET.Test.Sdk 17.3.3.
2. Verify that the project code is compatible with the major version upgrades of Newtonsoft.Json (v13) and System.Collections.Immutable (v5).

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment on lines +174 to +175
"Newtonsoft.Json": "[13.0.1, )",
"System.Collections.Immutable": "[5.0.0, )"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

This update triggers major version upgrades for core project dependencies: Newtonsoft.Json (12.0.2 -> 13.0.1) and System.Collections.Immutable (1.5.0 -> 5.0.0). These jumps can introduce breaking changes in serialization defaults and collection behavior. If this project is consumed as a library, these upgrades may also force breaking changes onto downstream users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants