Skip to content

ci: run vscode + dashboard vitest unit suites in CI (only codev runs today) #967

@amrmelsayed

Description

@amrmelsayed

Gap

The Tests workflow (.github/workflows/test.yml) and the e2e workflows only run packages/codev vitest (unit / integration / cli). The only other package exercised in CI is the dashboard, and dashboard-e2e.yml runs Playwright e2e only — not its vitest unit suite.

As of #961, packages/core was added to the unit job (it had no suite before). That leaves two unit suites with no CI coverage at all:

Package Suite Runs in CI?
packages/codev vitest (unit + vitest.e2e.config.ts + vitest.cli.config.ts) test.yml, e2e.yml
packages/core vitest run test.yml (added in #961)
packages/dashboard vitest unit (__tests__/*.test.ts(x)) ❌ local only
packages/dashboard Playwright e2e dashboard-e2e.yml
packages/vscode test:unit (vitest run, ~222 tests) + vscode-test ❌ local only

Why it matters

These suites cover real behavior — e.g. the dashboard Terminal.reconnect.test.tsx and the vscode terminal-adapter.test.ts close-loop. A regression in either passes CI today. #961 touched both of those suites; the edits only ran on the builder's machine, never in CI.

Proposed work

Add CI steps (jobs or steps in test.yml) that run:

  • packages/vscodepnpm test:unit (vitest)
  • packages/dashboard → its vitest unit suite (separate from the Playwright e2e job)

Worth deciding while doing it:

Context

Discovered during #961 (extract transport-agnostic reconnect policy), which added the packages/core unit step and made the single-package CI coverage visible.

Metadata

Metadata

Assignees

Labels

area/cross-cuttingTouches multiple areas — needs coordinated handling

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions