Triage labels for WIP tests #132
slott56
started this conversation in
CEL-Spec Compliance
Replies: 1 comment
-
|
PR #174 will add even more test cases marked |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Triage Labels
PR #131 introduced about 1200 test cases marked
@wip. These need some kind of triage process to help prioritize and address the work.Triage in general requires at least 3 categories: won't-fix, must-fix-now, and will-fix-later.
Things related to protobuf, I feel can be lumped into won't-fix. It's not as widely used in the Python world. I think it's a distraction from the underlying purposes of extending C7N to include easier-to-read logic expressions and computations.
The must-fix-now and will-fix-later tags have a more subtle distinction. I think I could be driven by (a) how clear the affected code is and (b) how soon someone can get to the change. It may be clear but you can't get to it right away. In that case, an issue can have detailed notes that stage something as will-fix-later. The will-fix-now are ones where the change is clear and (perhaps) already tested in a branch.
So. Question 1 is "What labels should we use?"
Beta Was this translation helpful? Give feedback.
All reactions