You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 16, 2023. It is now read-only.
I'm building ZSH completion for stman and since I've covered all of the sub-commands and their sub-commands etc. , I have a few enhancements suggestions:
device vs server terminology
Currently, there is a global flag called --device which chooses the device configured in syncthingmanager's configuration file. It seems it would have been better to call rename it to --server so it won't be confused with device related commands?
Editing folders
I've noticed that there is both the stman folder edit command and stman folder versioning command. Both of these commands seem to use SyncthingManager.folder_edit so perhaps it would have been better to put everything under another subparser? I think this would could be more consistent with the structure of the whole XML file that is actually used in the API calls.
Undocumented / missing extra parameters for stman folder versioning:
In addition to the previous topic, some versioning options have additional arguments. According to my tests only the external versioning scheme works when an additional argument (the external command) is provided. Providing any additional argument for the simple or the staggered versioning schemes is not supported and certain default values are used instead.
I'd be happy to know your opinion because I'd like to contribute fixes to these issues. I have a few other suggestions not covered here that might contribute as well but most importantly, aid when it'll be time for the ZSH completion to be submitted, depending on your approval.
Hello @classicsc,
I'm building ZSH completion for
stmanand since I've covered all of the sub-commands and their sub-commands etc. , I have a few enhancements suggestions:devicevsserverterminologyCurrently, there is a global flag called
--devicewhich chooses the device configured in syncthingmanager's configuration file. It seems it would have been better to call rename it to--serverso it won't be confused withdevicerelated commands?Editing folders
I've noticed that there is both the
stman folder editcommand andstman folder versioningcommand. Both of these commands seem to useSyncthingManager.folder_editso perhaps it would have been better to put everything under anothersubparser? I think this would could be more consistent with the structure of the whole XML file that is actually used in the API calls.Undocumented / missing extra parameters for
stman folder versioning:In addition to the previous topic, some versioning options have additional arguments. According to my tests only the
externalversioning scheme works when an additional argument (the external command) is provided. Providing any additional argument for thesimpleor thestaggeredversioning schemes is not supported and certain default values are used instead.I'd be happy to know your opinion because I'd like to contribute fixes to these issues. I have a few other suggestions not covered here that might contribute as well but most importantly, aid when it'll be time for the ZSH completion to be submitted, depending on your approval.