Skip to content

Commit fece78e

Browse files
maskri17copybara-github
authored andcommitted
Implement strings.format in CEL string extensions.
PiperOrigin-RevId: 958621592
1 parent d5f903b commit fece78e

5 files changed

Lines changed: 647 additions & 20 deletions

File tree

conformance/src/test/java/dev/cel/conformance/BUILD.bazel

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,6 @@ _TESTS_TO_SKIP_LEGACY = [
115115

116116
# Skip until fixed.
117117
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",
118-
# TODO: Add strings.format.quote.
119-
"string_ext/format",
120-
"string_ext/format_errors",
121118

122119
# Future features for CEL 1.0
123120
# TODO: Strong typing support for enums, specified but not implemented.
@@ -143,10 +140,6 @@ _TESTS_TO_SKIP_LEGACY = [
143140
]
144141

145142
_TESTS_TO_SKIP_PLANNER = [
146-
# TODO: Add strings.format.
147-
"string_ext/format",
148-
"string_ext/format_errors",
149-
150143
# TODO: This is actually a user experience degradation.
151144
# Not worth fixing until we see a concrete need.
152145
"basic/functions/unbound_is_runtime_error",

extensions/src/main/java/dev/cel/extensions/BUILD.bazel

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,12 @@ java_library(
8989
"//checker:checker_builder",
9090
"//common:compiler_common",
9191
"//common/internal",
92+
"//common/internal:comparison_functions",
93+
"//common/internal:date_time_helpers",
9294
"//common/types",
95+
"//common/types:type_providers",
96+
"//common/values",
97+
"//common/values:cel_byte_string",
9398
"//compiler:compiler_builder",
9499
"//extensions:extension_library",
95100
"//runtime",

0 commit comments

Comments
 (0)