Skip to content

Commit 9135e2f

Browse files
committed
fix tests
1 parent f563dd2 commit 9135e2f

4 files changed

Lines changed: 8 additions & 5 deletions

File tree

ext/reflection/php_reflection.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9053,6 +9053,9 @@ static void reflection_collect_interface_bindings(
90539053
if (!intermediate || intermediate == ancestor) {
90549054
continue;
90559055
}
9056+
if (zend_class_is_monomorph(intermediate)) {
9057+
continue;
9058+
}
90569059
if (generic_implements
90579060
&& zend_hash_index_exists(generic_implements, i - parent_count)) {
90589061
continue;
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--TEST--
2-
Reflection: ReflectionNamedType::getName() returns the erased name
2+
Reflection: ReflectionNamedType::getName() returns the reified name with type arguments
33
--FILE--
44
<?php
55
class Box<T> {}
@@ -9,5 +9,5 @@ echo $r->getParameters()[0]->getType()->getName(), "\n";
99
echo $r->getReturnType()->getName(), "\n";
1010
?>
1111
--EXPECT--
12-
Box
13-
Box
12+
Box<int>
13+
Box<string>

ext/reflection/tests/generics/nested_args.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ $inmost = $inner->getGenericArguments()[0];
1212
echo $inmost->getName(), "\n";
1313
?>
1414
--EXPECT--
15-
Box
15+
Box<Box<int>>
1616
Box
1717
int

ext/reflection/tests/generics/property_type_args.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ echo count($rt->getGenericArguments()), "\n";
1212
echo $rt->getGenericArguments()[0]->getName(), "\n";
1313
?>
1414
--EXPECT--
15-
Box
15+
Box<int>
1616
1
1717
int

0 commit comments

Comments
 (0)