Extract EqualityValueSet for filter value set re-use#1239
Merged
myronmarston merged 2 commits intoJun 5, 2026
Merged
Conversation
… extraction. Introduces `EqualityValueSet`, extracted from `RoutingValueSet`, to serve as a reusable inclusive/exclusive set for use with `FilterValueSetExtractor`. Adds `FilterValueSetExtractor.for_equality` as a factory method to reduce boilerplate for callers.
marcdaniels-toast
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch and
myronmarston
as code owners
myronmarston
requested changes
Jun 5, 2026
myronmarston
left a comment
myronmarston
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for doing this extraction as its own PR! It makes review easy :).
Contributor
Author
|
Oops, sorry I forgot to run quick_build on this branch before I posted it. In too much of a hurry to put up this PR. I'll fix it up! |
- Move to `Filtering` namespace (alongside its only caller, `FilterValueSetExtractor`) - Remove uncovered `include?` method (will be re-introduced in follow-up PR) - Restore `get_included_and_excluded_values` private helper, collapsing the two-branch mixed inclusive/exclusive case in `union` to a single branch - Update class comment per reviewer suggestion - Drop now-unnecessary `@dynamic` annotation Generated with Claude Code
myronmarston
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EqualityValueSet, extracted from the formerRoutingValueSet, as a reusable inclusive/exclusive set withunion,intersection, andnegateoperationsRoutingValueSetentirely — its two-line conversion logic now lives inline inRoutingPicker#extract_eligible_routing_valuesFilterValueSetExtractor.for_equalityas a factory method that configures an extractor forequal_to_any_offilters usingEqualityValueSet, reducing boilerplate for callersThis is a preliminary refactor in support of
__typename-based index narrowing (#1179), whereEqualityValueSetandFilterValueSetExtractor.for_equalitywill be reused by the new narrowing logic.