Very minor issue all things considered, in hackney 1.x, the {:socks5, ProxyHost, ProxyPort} branch in maybe_proxy had no guard clause, and passed through :hostname to gen_tcp:connect, the new get_proxy_config function added a is_list(ProxyHost) guard which silently falls through to _ -> false and ignores the proxy.
Great work on the 4.0 release!
Very minor issue all things considered, in hackney 1.x, the {:socks5, ProxyHost, ProxyPort} branch in maybe_proxy had no guard clause, and passed through :hostname to gen_tcp:connect, the new get_proxy_config function added a is_list(ProxyHost) guard which silently falls through to _ -> false and ignores the proxy.
Great work on the 4.0 release!