refactor(tests): create conftest py_library target#3947
Merged
rickeylev merged 3 commits intoJul 23, 2026
Conversation
Split conftest.py into its own py_library target under tests/tools/private/release. Add :conftest as a dependency to all pytest_test targets in tests/tools/private/release/BUILD.bazel.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
# Conflicts: # tests/tools/private/release/BUILD.bazel
rickeylev
enabled auto-merge
July 23, 2026 02:59
Set testonly = True on the conftest py_library target in tests/tools/private/release/BUILD.bazel.
aignas
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor test/tools/private/release tests such that conftest.py is its own py_library target, and add it as a dependency to targets that directly need it.