From e2cecf3c81dcc68a9b909a8e3cb8c94c637861cc Mon Sep 17 00:00:00 2001 From: Karl Bauer Date: Sat, 10 Oct 2026 21:19:19 +0200 Subject: [PATCH] ci(dependabot): removed the paths filter from the auto-merge caller The caller only started for the two src Dockerfiles, so pip updates of rabbitmq-init (requirements*.txt) never reached the auto-merge module: no decision, no annotation, the PR just stayed open. Without the filter every Dependabot PR is decided and annotated by the module. Per ecosystem: * docker (src/rabbitmq, src/rabbitmq-init) - unchanged, the PR run of docker-release.yml builds both images * pip (src/rabbitmq-init) - can now auto-merge: docker-release.yml already runs on src/**, installs requirements-test.txt (which pulls in requirements.txt), runs pytest and builds the rabbitmq-init image * docker-compose - the compose files reference images only through ${VAR:-...}:${VAR:-latest}, which Dependabot cannot update; it has opened no PR since June * github-actions - still left open by the module's own .github/ guard Not changed: required-workflows (docker-release.yml), the write permissions (the repository is public, so the read scopes are not needed), merge method, auto-approve and the module default of merging patch updates only. docker-release.yml needs no wider paths: src/** already covers every manifest Dependabot updates there. --- .github/workflows/docker-maintenance.yml | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/.github/workflows/docker-maintenance.yml b/.github/workflows/docker-maintenance.yml index 61dd1d4..ae01f55 100644 --- a/.github/workflows/docker-maintenance.yml +++ b/.github/workflows/docker-maintenance.yml @@ -1,11 +1,17 @@ # ============================================================================= -# Docker Maintenance — Auto-merge Dependabot PRs (src Dockerfiles) +# Docker Maintenance — Auto-merge Dependabot PRs (all ecosystems) # ============================================================================= -# When Dependabot opens a PR bumping a base image inside: -# - src/rabbitmq/Dockerfile (rabbitmq:*-management) -# - src/rabbitmq-init/Dockerfile (python:3.14-alpine) -# this workflow auto-approves and merges it (after validation passes), which -# then triggers docker-release.yml to build and push the updated image. +# No paths: filter - every Dependabot PR reaches the module and gets an +# explicit decision and annotation instead of silently staying open. It is +# merged only after docker-release.yml ran on its head commit and passed: +# - docker src/*/Dockerfile -> the PR run builds both images +# - pip src/rabbitmq-init/requirements*.txt +# -> the PR run installs them, runs +# pytest and builds rabbitmq-init +# - docker-compose: the compose files reference images only via +# ${VAR:-...}:${VAR:-latest}, which Dependabot cannot update +# - github-actions and any other .github/ change stay open (manual merge) +# Only patch updates are merged (module default for merge-update-types). # ============================================================================= name: 🔧 Docker Maintenance @@ -13,9 +19,6 @@ name: 🔧 Docker Maintenance on: pull_request: types: [opened, synchronize, reopened, ready_for_review] - paths: - - 'src/rabbitmq/Dockerfile' - - 'src/rabbitmq-init/Dockerfile' permissions: contents: write