Skip to content

mypy --strict is only run against one example file, never against the library's own source #142

Description

@codeforester

Summary

CI's mypy invocations target only examples/typed_consumer.py, never the actual package.

Details

.github/workflows/tests.yml:43 and :63 both run mypy only against examples/typed_consumer.py. The package (lib/python/base_cli, ~9,450 lines, fully annotated with from __future__ import annotations, shipping a py.typed marker per pyproject.toml:82-83) is never type-checked by CI. The py.typed marker is a PEP 561 promise to consumers that the library's types are correct.

Impact

Type errors inside the library itself can land undetected indefinitely while downstream consumers rely on its type stubs being accurate.

Suggested fix

Add python -m mypy --strict lib/python/base_cli (or at least non-strict) to the quality job.

Metadata

Metadata

Assignees

Labels

ciContinuous integration, tests, automation, or release workflowsenhancementNew feature or product improvement

Type

No type

Projects

Status
Triage

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions