Problem
The masking-findings gate fails on pristine main with 25 pre-existing findings (up from 15 when the #763 work was briefed). Because the gate runs pre-push, every contributor must push with --no-verify to land anything — which also skips every other pre-push check, so the gate's growth is silently eroding the whole hook.
Evidence
Suggested resolution
- Triage the 25 findings on
main: fix the real ones, suppress false positives with justified nosemgrep annotations.
- Once
main is clean, the gate becomes meaningful again and --no-verify stops being the default workflow.
- Consider a baseline/ratchet mechanism (fail only on new findings) if a full cleanup can't land soon, so the gate blocks regressions without blocking unrelated work.
Origin
Found during PR #763 — see the merge-guidance comment: #763 (comment)
Problem
The masking-findings gate fails on pristine
mainwith 25 pre-existing findings (up from 15 when the #763 work was briefed). Because the gate runs pre-push, every contributor must push with--no-verifyto land anything — which also skips every other pre-push check, so the gate's growth is silently eroding the whole hook.Evidence
main(no branch changes applied): 25 findings.--no-verifyfor this gate only; nonosemgrepsuppressions were added, so the findings remain visible.Suggested resolution
main: fix the real ones, suppress false positives with justifiednosemgrepannotations.mainis clean, the gate becomes meaningful again and--no-verifystops being the default workflow.Origin
Found during PR #763 — see the merge-guidance comment: #763 (comment)