Skip to content

25 pre-existing masking findings on main fail the pre-push gate, forcing --no-verify for every contributor #766

Description

@theagenticguy

Problem

The masking-findings gate fails on pristine main with 25 pre-existing findings (up from 15 when the #763 work was briefed). Because the gate runs pre-push, every contributor must push with --no-verify to land anything — which also skips every other pre-push check, so the gate's growth is silently eroding the whole hook.

Evidence

Suggested resolution

  1. Triage the 25 findings on main: fix the real ones, suppress false positives with justified nosemgrep annotations.
  2. Once main is clean, the gate becomes meaningful again and --no-verify stops being the default workflow.
  3. Consider a baseline/ratchet mechanism (fail only on new findings) if a full cleanup can't land soon, so the gate blocks regressions without blocking unrelated work.

Origin

Found during PR #763 — see the merge-guidance comment: #763 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingci-cdBuild pipeline, deploy.yml, CI perf/caching, GitHub Actions workflowstooling

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions