fix: EventBridgeEvent data class (#8301)

* fix: EventBridgeEvent data class

* refactor: improve namings, add docstring

* address comment on issue 8300

* fix small things

---------

Co-authored-by: Amin Farjadi <amin.farjadi@eonnext.com>
Co-authored-by: Leandro Damascena <lcdama@amazon.pt>

Author: 3 people

aws_lambda_powertools/utilities/data_classes/event_bridge_event.py

@@ -68,4 +68,4 @@ def detail(self) -> dict[str, Any]:
     @property
     def replay_name(self) -> str | None:
         """Identifies whether the event is being replayed and what is the name of the replay."""
-        return self["replay-name"]
+        return self.get("replay-name")

tests/events/eventBridgeEvent.json

@@ -6,12 +6,9 @@
   "account": "111122223333",
   "time": "2017-12-22T18:43:48Z",
   "region": "us-west-1",
-  "resources": [
-    "arn:aws:ec2:us-west-1:123456789012:instance/i-1234567890abcdef0"
-  ],
+  "resources": [],
   "detail": {
     "instance_id": "i-1234567890abcdef0",
     "state": "terminated"
-  },
-  "replay-name": "replay_archive"
-}
+  }
+}

tests/unit/data_classes/required_dependencies/test_event_bridge_event.py

@@ -17,4 +17,4 @@ def test_event_bridge_event():
     assert parsed_event.source == raw_event["source"]
     assert parsed_event.detail_type == raw_event["detail-type"]
     assert parsed_event.detail == raw_event["detail"]
-    assert parsed_event.replay_name == "replay_archive"
+    assert parsed_event.replay_name is None

tests/unit/parser/_pydantic/test_eventbridge.py

@@ -45,7 +45,7 @@ def test_handle_eventbridge_trigger_event_no_envelope():
     assert parsed_event.resources == raw_event["resources"]
     assert parsed_event.source == raw_event["source"]
     assert parsed_event.detail_type == raw_event["detail-type"]
-    assert parsed_event.replay_name == raw_event["replay-name"]
+    assert parsed_event.replay_name is None
 
 
 def test_handle_invalid_event_with_eventbridge_envelope():