refactor: migrate from nunjucks to react-sdk for code generation and handle curly-braces in operationID#386
Merged
Merged
Conversation
Broadly, the code changes covers the following: - Efficient schema handling and class generation (for both JSON and AVRO) - Support for complex JSON and AVRO schema (inheritences, nested objects and complex schema settings) - Support for schema settings around field formats, constraints etc - Proper binder configuration (for Solace, Kafka and RabbitMQ) - Solace-specific: Queue/Topic handing in the binding configuration - Revamped integration.test with support scripts for generating code from asyncapi files in mocks and compiling the generated code, generate report - Support for all the template parameters and x-* custom overrides
gvensan
requested review from
CameronRushton and
asyncapi-bot-eve
as code owners
gvensan
changed the title
- Add missing toJavaClassName import in ApplicationYml.js - Fix duplicate 'properties' key in avroProcessor.js (renamed to propertiesArray) - Move ModelClass definition before SchemaModel to fix use-before-define - Refactor nested ternary expressions into helper functions - Fix brace-style issues (else-if on same line) - Fix lonely-if by converting to else-if chain - Add radix parameter to parseInt() - Prefix intentionally unused variables with underscore - Remove unused destructured variables in coreProcessor.js - Update .eslintrc to ignore vars/args prefixed with underscore - Add .eslintignore to exclude build artifacts
gvensan
changed the title
Member
|
Nothing blocking. Let's have this merged. Thanks for all your hard work! |
Comment on lines
+257
to
+259
| expect(appJava).toContain('package com.company;'); | ||
| expect(appJava).toContain('import org.springframework.boot.SpringApplication;'); | ||
| expect(appJava).toContain('import org.springframework.boot.autoconfigure.SpringBootApplication;'); |
Member
There was a problem hiding this comment.
These expectations feel like a regression from the snapshot testing that was had in the last repo, since it was more thorough with checking the entire file for changes.
CameronRushton
previously approved these changes
Jan 27, 2026
- Create utils/processorUtils.js with shared processor functions - Create utils/schemaModel/BaseSchemaModel.js for common schema logic - Create utils/packageUtils.js for AVRO package extraction - Refactor avroProcessor and jsonProcessor to use shared utilities - Refactor hooks/pre-process.js and post-process.js - Add helper functions to components/Application.js - Add test/run_output.sh script for running generated projects
|
CameronRushton
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)