From 71933d09981463dfe19a1de8d4dd176c5cf80583 Mon Sep 17 00:00:00 2001 From: spricoder Date: Fri, 12 Jun 2026 17:50:22 +0800 Subject: [PATCH] Remove unused PROJECT_SRC_DIR from cpp CMakeLists The variable was introduced in #364 but has never been referenced anywhere in the build. Per maintainer guidance, consumers (CLI, tests, examples, external users) must resolve library headers from the staged include tree (LIBRARY_INCLUDE_DIR) and link the shared library, never reach into the source tree, so a variable pointing at cpp/src should not exist as a temptation. Verified: full Debug build (library + tsfile-cli + TsFile_Test) and the complete GTest suite (641 tests) pass; tsfile-cli write/count/cat round-trip works. --- cpp/CMakeLists.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index 319752482..0de87bc7d 100755 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -244,9 +244,6 @@ endif() # All libs will be stored here, including libtsfile, compress-encoding lib. set(LIBRARY_OUTPUT_PATH ${PROJECT_BINARY_DIR}/lib) -# TsFile code will be stored here. -set(PROJECT_SRC_DIR ${PROJECT_SOURCE_DIR}/src) - # All include files will be installed here. # Use global var so that tests may also use this set(LIBRARY_INCLUDE_DIR ${PROJECT_BINARY_DIR}/include CACHE STRING "TsFile includes")