fix(deps, pyamber): update dependency setuptools to v83 [security] - #6911
fix(deps, pyamber): update dependency setuptools to v83 [security]#6911renovate-bot wants to merge 1 commit into
Conversation
|
👋 Thanks for opening this pull request, @renovate-bot! It looks like the pull request description doesn't quite follow our template yet:
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed. You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow. |
Automated Reviewer SuggestionsBased on the
|
|
Plan to remove setuptools: issue #6917 |
|
Since its a required library by another one, I suggest we remove it. @renovate-bot can you check which other library is using it and if possible just remove it so the other library can install the version it needs? this way we avoid conflict |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6911 +/- ##
=========================================
Coverage 78.70% 78.70%
Complexity 3740 3740
=========================================
Files 1161 1161
Lines 46084 46084
Branches 5110 5110
=========================================
Hits 36269 36269
Misses 8206 8206
Partials 1609 1609
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 366 | 0.224 | 26,586/35,502/35,502 us | 🔴 +12.3% / 🔴 +118.7% |
| 🔴 | bs=100 sw=10 sl=64 | 766 | 0.467 | 127,849/168,800/168,800 us | 🔴 +21.9% / 🔴 +55.4% |
| ⚪ | bs=1000 sw=10 sl=64 | 896 | 0.547 | 1,115,622/1,161,408/1,161,408 us | ⚪ within ±5% / 🔴 +11.6% |
Baseline details
Latest main f521750 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 366 tuples/sec | 383 tuples/sec | 767.9 tuples/sec | -4.4% | -52.3% |
| bs=10 sw=10 sl=64 | MB/s | 0.224 MB/s | 0.234 MB/s | 0.469 MB/s | -4.3% | -52.2% |
| bs=10 sw=10 sl=64 | p50 | 26,586 us | 23,672 us | 12,502 us | +12.3% | +112.7% |
| bs=10 sw=10 sl=64 | p95 | 35,502 us | 36,845 us | 16,234 us | -3.6% | +118.7% |
| bs=10 sw=10 sl=64 | p99 | 35,502 us | 36,845 us | 18,919 us | -3.6% | +87.7% |
| bs=100 sw=10 sl=64 | throughput | 766 tuples/sec | 803 tuples/sec | 974.8 tuples/sec | -4.6% | -21.4% |
| bs=100 sw=10 sl=64 | MB/s | 0.467 MB/s | 0.49 MB/s | 0.595 MB/s | -4.7% | -21.5% |
| bs=100 sw=10 sl=64 | p50 | 127,849 us | 122,702 us | 102,449 us | +4.2% | +24.8% |
| bs=100 sw=10 sl=64 | p95 | 168,800 us | 138,429 us | 108,652 us | +21.9% | +55.4% |
| bs=100 sw=10 sl=64 | p99 | 168,800 us | 138,429 us | 116,310 us | +21.9% | +45.1% |
| bs=1000 sw=10 sl=64 | throughput | 896 tuples/sec | 901 tuples/sec | 1,004 tuples/sec | -0.6% | -10.8% |
| bs=1000 sw=10 sl=64 | MB/s | 0.547 MB/s | 0.55 MB/s | 0.613 MB/s | -0.5% | -10.7% |
| bs=1000 sw=10 sl=64 | p50 | 1,115,622 us | 1,109,081 us | 999,606 us | +0.6% | +11.6% |
| bs=1000 sw=10 sl=64 | p95 | 1,161,408 us | 1,182,818 us | 1,046,770 us | -1.8% | +11.0% |
| bs=1000 sw=10 sl=64 | p99 | 1,161,408 us | 1,182,818 us | 1,076,937 us | -1.8% | +7.8% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,545.98,200,128000,366,0.224,26585.57,35501.86,35501.86
1,100,10,64,20,2611.41,2000,1280000,766,0.467,127848.60,168800.45,168800.45
2,1000,10,64,20,22332.84,20000,12800000,896,0.547,1115621.53,1161408.22,1161408.22
This PR contains the following updates:
==80.10.2→==83.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
setuptools: MANIFEST.in exclusion bypass in sdist via Unicode normalization collision (NFC/NFD) on macOS APFS/HFS+
BIT-setuptools-2026-59890 / CVE-2026-59890 / GHSA-h35f-9h28-mq5c / PYSEC-2026-3447
More information
Details
Summary
When building a source distribution (
python -m build --sdist/setup.py sdist), setuptools'FileListappliesMANIFEST.indirectives (exclude,global-exclude,recursive-exclude,prune) by matching a compiled glob against on-disk file names byte-for-byte, with no Unicode normalization. On normalization-preserving filesystems (notably macOS APFS and HFS+), a file written in NFD and aMANIFEST.inrule written in NFC refer to the same file but are byte-distinct, so the exclusion silently fails to match. A file the maintainer intended to exclude is then packed into the.tar.gzand, if published, uploaded to the public, immutable PyPI index.Details
File names in
FileList.filescome fromos.walk(setuptools/_distutils/filelist.py,_find_all_simple), so on APFS a file written NFD is offered to the matcher in NFD, while theMANIFEST.inpattern carries the author's editor form (typically NFC). The matching path performs no canonicalization:A rule written NFC (
café=63 61 66 c3 a9) does not match an on-disk name written NFD (café=63 61 66 65 cc 81), even though the filesystem treats the two as one file.A
unicodedata.normalize('NFD', ...)helper exists insetuptools/unicode_utils.py(decompose()), but it is never called in the manifest matching path, so neither the pattern nor the walked path is normalized before matching. The only normalization in this area,EggInfoCommand._manifest_normalize, usesfilesys_decode(bytes→str decode only, no NFC/NFD) and runs when writingSOURCES.txt, after matching has already occurred.Impact
MANIFEST.inexclusions are the documented mechanism maintainers use to keep secrets, local configs, and private fixtures out of the published sdist. A non-ASCII excluded file may be published to the public, immutable PyPI index despite the rule — an irreversible disclosure with no visual cue (NFC and NFD forms render identically). Exposure is filesystem-dependent and most relevant on macOS APFS/HFS+, where many maintainers build and publish. Pure-ASCII rules are unaffected.Proof of concept
With a project containing
MANIFEST.in:and an on-disk file
secret_café.txtwritten in NFD,python -m build --sdistpacks the secret file into the resulting.tar.gz, while an ASCII control file excluded by the same directive is correctly dropped — isolating the bypass to the NFC-pattern vs. NFD-name mismatch. Reproduced on macOS APFS with setuptools 82.0.1.Remediation
Normalize both the walked path and each
MANIFEST.inpattern to a single canonical form before matching, in bothsetuptools/command/egg_info.py(FileList) and the vendoredsetuptools/_distutils/filelist.py. For an exclusion list, err toward excluding more, and document thatMANIFEST.inmatching is normalization-insensitive on macOS.Credit
Reported by Tomas Illuminati. Coordinated via CERT/CC VINCE VU#604762.
Severity
CVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:L/A:NReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
BIT-setuptools-2026-59890 / CVE-2026-59890 / GHSA-h35f-9h28-mq5c / PYSEC-2026-3447
More information
Details
setuptools is a package that allows users to download, build, install, upgrade, and uninstall Python packages. Prior to 83.0.0, FileList applied MANIFEST.in exclude, global-exclude, recursive-exclude, and prune directives by matching compiled glob patterns against on-disk file names without Unicode normalization, so on macOS APFS or HFS+ an NFD file name could bypass an NFC exclusion rule and be packed into a source distribution. This issue is fixed in version 83.0.0.
Severity
CVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:L/A:NReferences
This data is provided by OSV and the PyPI Advisory Database (CC-BY 4.0).
Release Notes
pypa/setuptools (setuptools)
v83.0.0Compare Source
v82.0.1Compare Source
v82.0.0Compare Source
v81.0.0Compare Source
Configuration
📅 Schedule: (in timezone Etc/UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.